Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate clang-format action for ideas on customisable docker base image #100

Open
ZedThree opened this issue Nov 8, 2023 · 2 comments

Comments

@ZedThree
Copy link
Owner

ZedThree commented Nov 8, 2023

See https://github.com/jidicula/clang-format-action

Top-level action is a composite action and somehow controls the base image used for the docker image. This allows them to support lots of clang-format versions. Potentially could do something similar here to also allow running in parent image, without needing to do the faff with installing packages inside our action's container. Or it might not work at all.

@eguiraud
Copy link

Hi, there is another important use-case for this: the way clang-tidy-review currently works, it always runs on ubuntu 23.04, which sometimes has incompatible library versions w.r.t. the system where the compile_commands.json was generated.

In my case, the system where I run the build is (read: must be) Ubuntu 22.04, which ships Python 3.10, so clang-tidy inside the 23.04 docker image (which ships Python 3.11) can't find the Python.h header at the location indicated by the compile_commands.json.

@ZedThree
Copy link
Owner Author

I'd really really like to implement this, I just don't have time to investigate properly at the moment! If there's anyone reading this who's interested, please feel free to give it a crack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants