Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logging via Zap Logger #49

Open
uzaxirr opened this issue Jan 3, 2023 · 2 comments · May be fixed by #59
Open

Add Logging via Zap Logger #49

uzaxirr opened this issue Jan 3, 2023 · 2 comments · May be fixed by #59
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@uzaxirr
Copy link
Member

uzaxirr commented Jan 3, 2023

Is your feature request related to a problem? Please describe.
Currently we use the traditional golang log package for logging purpose, however its not sufficient as it lacks a lot of basic functionality like an error level log.

Describe the solution you'd like
Use Zap Logger and replace all the occurrence of log package with this one. Also add new logger statements whenever necessary.

Describe alternatives you've considered
logrus

@uzaxirr uzaxirr added enhancement New feature or request good first issue Good for newcomers labels Jan 3, 2023
@chauhan17nitin
Copy link
Contributor

Hi, @uzaxirr let me know if i can pick this,

planning to integrate a singleton Zap Logger, with TransactionID support in context,

which will ultimately help to track all logs related to a single request using a single filter on all logs.

@abskrj
Copy link
Member

abskrj commented Jan 7, 2023

sure, @chauhan17nitin
assigning it to you

@chauhan17nitin chauhan17nitin linked a pull request Jan 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants