Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoIP Object #3

Open
Zakay opened this issue Oct 13, 2011 · 2 comments
Open

GeoIP Object #3

Zakay opened this issue Oct 13, 2011 · 2 comments

Comments

@Zakay
Copy link
Owner

Zakay commented Oct 13, 2011

Current Requirements:

  • Constructor that takes an optional argument for changing db directory, and destructor to reset to default / php.ini.
@katanacrimson
Copy link

Digging around on PHP.net, found this issue that it might be worth working around: http://us2.php.net/manual/en/geoip.setup.php#103742

When setting the directory, making sure the files to be used are readable could save some sanity - instead of the developer having to call geoip_db_avail themselves, just throw an exception if the database file(s) are unusable. After all, if the app developer is instantiating an object to load up the geoip database, they're not doing it for grins, it's because they're going to use it in some fashion (get the db info, look something up, whatever).

@Zakay
Copy link
Owner Author

Zakay commented Oct 14, 2011

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants