Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After an issue edit, github-actions bot removes existing priority label #1126

Open
2 tasks done
xayanide opened this issue Apr 12, 2024 · 1 comment
Open
2 tasks done
Labels
branch:next Issues: Impacts next branch branch:stable Issues: Impacts stable branch priority:p3 Issues and PRs: Low priority status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added type:bug Issues and PRs: Related to a bug

Comments

@xayanide
Copy link
Member

xayanide commented Apr 12, 2024

Describe the bug

May not only apply with an issue edit.
Edit a bug report issue twice.
There should be a check in between steps 3 and 4 below that verifies if the label it is trying to apply already exists there, if it doesn't it removes the label, and applies the label that matches what was specified in the Severity dropdown of the issue.

Severity

Low

Affected branches

  • Stable
  • Next

Quaver version

Unrelated to the discord bot.

Steps to reproduce

  1. Submits a bug report issue without any priority label.
  2. github-actions applies the label (correct)
  3. Edit the issue again (currently it had priority label it belongs to.)
  4. github-actions removes the label (incorrect)

Expected behavior

Verify first if the label that is about to get applied matches from what was selected in the selected priority section in the issue and keep the label intact. Only apply labels when it doesn't match that condition or the issue had no priority label.

Actual behavior

Removes existing priorty label

Relevant log output

No response

@xayanide xayanide added type:bug Issues and PRs: Related to a bug priority:p3 Issues and PRs: Low priority status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added and removed priority:p3 Issues and PRs: Low priority labels Apr 12, 2024
@github-actions github-actions bot added priority:p3 Issues and PRs: Low priority and removed priority:p3 Issues and PRs: Low priority labels Apr 12, 2024
@xayanide xayanide changed the title After an issue edit twice, the priority label gets removed by github-actions bot After an issue edit, the priority label gets removed or added back Apr 12, 2024
@xayanide xayanide added type:bug Issues and PRs: Related to a bug priority:p3 Issues and PRs: Low priority branch:next Issues: Impacts next branch branch:stable Issues: Impacts stable branch and removed type:bug Issues and PRs: Related to a bug labels Apr 12, 2024
@xayanide
Copy link
Member Author

It would be nice if GitHub Actions bot could also apply relevant labels to issues where checkboxes are ticked in the "Affected Branches" section.

@github-actions github-actions bot removed the priority:p3 Issues and PRs: Low priority label Apr 12, 2024
@xayanide xayanide changed the title After an issue edit, the priority label gets removed or added back After an issue edit, github-actions bot removes or adds the label. Apr 12, 2024
@xayanide xayanide changed the title After an issue edit, github-actions bot removes or adds the label. After an issue edit, github-actions bot removes or reassigns existing priority label Apr 12, 2024
@xayanide xayanide changed the title After an issue edit, github-actions bot removes or reassigns existing priority label After an issue edit, github-actions bot removes existing priority label Apr 12, 2024
@xayanide xayanide added the priority:p3 Issues and PRs: Low priority label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch:next Issues: Impacts next branch branch:stable Issues: Impacts stable branch priority:p3 Issues and PRs: Low priority status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added type:bug Issues and PRs: Related to a bug
Development

No branches or pull requests

1 participant