Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lavaclient event handlers listening to deprecated event names #1123

Open
2 tasks done
xayanide opened this issue Apr 12, 2024 · 2 comments · Fixed by #1127
Open
2 tasks done

Lavaclient event handlers listening to deprecated event names #1123

xayanide opened this issue Apr 12, 2024 · 2 comments · Fixed by #1127
Assignees
Labels
branch:next Issues: Impacts next branch branch:stable Issues: Impacts stable branch priority:p3 Issues and PRs: Low priority released on @next released status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added type:bug Issues and PRs: Related to a bug

Comments

@xayanide
Copy link
Member

xayanide commented Apr 12, 2024

Describe the bug

As of Lavaclient v5.0.0, there were changes to event names.
lavaclient/lavaclient#87

This was probably overlooked in 57fb40d

This results in a bug where Quaver's lavaclient event handlers for connect and disconnect to not work.

connect should now be connected
disconnect should now be disconnected

name: 'connect',

name: 'disconnect',

File names should follow the change respectively.

I learned about some new events in Lavaclient that might come in handy later:
The ready event
The queueCreate event.

Severity

Low

Affected branches

  • Stable
  • Next

Quaver version

7.0.1

Steps to reproduce

  1. Start Quaver

Expected behavior

Show an indication that Lavalink has either connected or disconnected.

Actual behavior

No indication.

Relevant log output

No response

@xayanide xayanide added the type:bug Issues and PRs: Related to a bug label Apr 12, 2024
@github-actions github-actions bot added priority:p3 Issues and PRs: Low priority status:proposed Issues and PRs: Pending confirmation labels Apr 12, 2024
@xayanide xayanide added branch:stable Issues: Impacts stable branch branch:next Issues: Impacts next branch priority:p3 Issues and PRs: Low priority status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added and removed priority:p3 Issues and PRs: Low priority status:proposed Issues and PRs: Pending confirmation labels Apr 12, 2024
@github-actions github-actions bot removed the priority:p3 Issues and PRs: Low priority label Apr 12, 2024
@xayanide xayanide added the priority:p3 Issues and PRs: Low priority label Apr 12, 2024
@xayanide xayanide changed the title Lavaclient event handlers listening to deprecated event names. Lavaclient event handlers listening to deprecated event names Apr 12, 2024
@github-actions github-actions bot removed the priority:p3 Issues and PRs: Low priority label Apr 12, 2024
@xayanide xayanide added the priority:p3 Issues and PRs: Low priority label Apr 12, 2024
@xayanide xayanide self-assigned this Apr 12, 2024
xayanide added a commit to xayanide/Quaver that referenced this issue Apr 12, 2024
xayanide added a commit to xayanide/Quaver that referenced this issue Apr 12, 2024
@xayanide xayanide linked a pull request Apr 12, 2024 that will close this issue
15 tasks
@zptx-bot
Copy link
Member

zptx-bot commented Jul 1, 2024

🎉 This issue has been resolved in version 7.0.2-next.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@zptx-bot
Copy link
Member

zptx-bot commented Jul 1, 2024

🎉 This issue has been resolved in version 7.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch:next Issues: Impacts next branch branch:stable Issues: Impacts stable branch priority:p3 Issues and PRs: Low priority released on @next released status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added type:bug Issues and PRs: Related to a bug
Development

Successfully merging a pull request may close this issue.

2 participants