Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated comments for PR #245 #248

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alexliyu7352
Copy link
Member

This PR contains translated comments for the merged PR #245

@wasphin
Copy link
Member

wasphin commented Sep 17, 2024

Do the comments in the back also need to be translated, or will they be automatically translated? It feels like manually writing dual versions of comments is more trouble, it's better to use an IDE translation plugin or something.

后面注释也都要翻译嘛,还是都会自动翻译?感觉如果是手动写双份注释比较麻烦,不如用个 ide 翻译插件啥的

TRANS_BY_GITHUB_AI_ASSISTANT

@alexliyu7352
Copy link
Member Author

alexliyu7352 commented Sep 17, 2024

Do the comments in the back also need to be translated, or will they be automatically translated? It feels like manually writing dual versions of comments is more trouble, it's better to use an IDE translation plugin or something.

后面注释也都要翻译嘛,还是都会自动翻译?感觉如果是手动写双份注释比较麻烦,不如用个 ide 翻译插件啥的

No need to write comments manually, like this one. AI will automatically translate and then submit a PR

Do the comments in the back also need to be translated, or will they be automatically translated? It feels like manually writing dual versions of comments is more trouble, it's better to use an IDE translation plugin or something.

后面注释也都要翻译嘛,还是都会自动翻译?感觉如果是手动写双份注释比较麻烦,不如用个 ide 翻译插件啥的

不需要手动写注释, 就像这个一样AI 会自动翻译, 然后自己提交pr

TRANS_BY_GITHUB_AI_ASSISTANT

@alexliyu7352
Copy link
Member Author

https://github.com/ZLMediaKit/Github-AI-Assistant/tree/main

提交patch后会自动对patch进行语义分割和向量化, 然后利用之前建立的向量数据库和索引作为上下文, AI自动生成review.
当patch被合并后, 会自动的针对patch中的中文注释生成一个翻译的pr并提交.所以不需要手动的翻译.

Do the comments in the back also need to be translated, or will they be automatically translated? It feels like manually writing dual versions of comments is more trouble, it's better to use an IDE translation plugin or something.

后面注释也都要翻译嘛,还是都会自动翻译?感觉如果是手动写双份注释比较麻烦,不如用个 ide 翻译插件啥的

TRANS_BY_GITHUB_AI_ASSISTANT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants