Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization bugs in Plot: Contour position dependent on spacing resolution #110

Closed
chrherold opened this issue Nov 30, 2021 · 7 comments
Closed
Labels
bug Something isn't working

Comments

@chrherold
Copy link

found the following unexpected behavior in Shape-Out 2.8.1:

The position of the contour lines seem not to match the density plot at all at some settings for spacing

Bildschirmfoto 2021-11-12 um 14 57 58

while they match the density plot for other spacing settings

Bildschirmfoto 2021-11-12 um 14 58 21

I can imagine that the spacing resolution influences the contour accuracy but I believe it should not completely mismatch
the contour position if the underlying density map has its maximum clearly elsewhere.

@chrherold chrherold added the bug Something isn't working label Nov 30, 2021
@paulmueller
Copy link
Member

paulmueller commented Nov 30, 2021

It certainly looks strange. Can I access that dataset somewhere? I could not reproduce it on my machine. I can reproduce it.

@paulmueller
Copy link
Member

paulmueller commented Nov 30, 2021

The thing is that the density map you see in the scatter plot is not identical to the density map used for contour computation.
Also note that Shape-Out computes the contour lines based on percentiles (events within a contour line). The artifacts that you are seeing are due to extremely large bins in the histogram binning method (The contour lines are generated with sub-bin-width accuracy, so to say). Here are a few examples that illustrate this:

image

image

image

Basically, whenever you have "kinks" in your contour line, your spacing is too large.

I have the feeling that it might be reasonable to automatically refine the spacing until there are no more kinks at the expense of the user having to wait longer for their plots.

@chrherold What do you think?

@paulmueller
Copy link
Member

paulmueller commented Dec 1, 2021

As discussed,

@paulmueller
Copy link
Member

paulmueller commented Dec 5, 2021

Bullet point 1 in my previous post is resolved with ebe507a and 88ab772.

Here is an example (note the red text):

image

And there is a new button in the plot tab for setting "sane" values to the contour spacing:

image

@chrherold Please have a look at the development release here and let me know whether we can release this temporary solution: https://ci.appveyor.com/project/paulmueller/shapeout2/builds/41778981/artifacts

If this works well enough, I would close this issue here. Regarding the second bullet point, see issue #111.

@chrherold
Copy link
Author

I tested the temporary solution and it works very well. Especially the find best spacing button does a very good job.

The indicator in the plot seems to move around a bit weirdly, if there is more than one row

image

And it shows multiple times if "One plot per dataset" is selected. Maybe it could be placed inside the plotting panels that contain a contour drawing. This way there would also not be some cutting out a part of the figure around it.

@paulmueller
Copy link
Member

Thanks for testing.
Please try the latest dev version: https://ci.appveyor.com/project/paulmueller/shapeout2/builds/41818695/artifacts
image

@chrherold
Copy link
Author

Works very well! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants