-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualization bugs in Plot: Contour position dependent on spacing resolution #110
Comments
It certainly looks strange. |
The thing is that the density map you see in the scatter plot is not identical to the density map used for contour computation. Basically, whenever you have "kinks" in your contour line, your spacing is too large. I have the feeling that it might be reasonable to automatically refine the spacing until there are no more kinks at the expense of the user having to wait longer for their plots. @chrherold What do you think? |
As discussed,
|
Bullet point 1 in my previous post is resolved with ebe507a and 88ab772. Here is an example (note the red text): And there is a new button in the plot tab for setting "sane" values to the contour spacing: @chrherold Please have a look at the development release here and let me know whether we can release this temporary solution: https://ci.appveyor.com/project/paulmueller/shapeout2/builds/41778981/artifacts If this works well enough, I would close this issue here. Regarding the second bullet point, see issue #111. |
I tested the temporary solution and it works very well. Especially the find best spacing button does a very good job. The indicator in the plot seems to move around a bit weirdly, if there is more than one row And it shows multiple times if "One plot per dataset" is selected. Maybe it could be placed inside the plotting panels that contain a contour drawing. This way there would also not be some cutting out a part of the figure around it. |
Thanks for testing. |
Works very well! Thanks! |
found the following unexpected behavior in Shape-Out 2.8.1:
The position of the contour lines seem not to match the density plot at all at some settings for spacing
while they match the density plot for other spacing settings
I can imagine that the spacing resolution influences the contour accuracy but I believe it should not completely mismatch
the contour position if the underlying density map has its maximum clearly elsewhere.
The text was updated successfully, but these errors were encountered: