Update isImage helper with file signatures #334
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The isImage helper function depends on the mime type and in certain cases it doesn't work as expected. See related issues.
To overcome this issues, using file signature inspection is proposed.
Type of change
How Has This Been Tested
Checklist
I haven't worked with JS for a while and haven't had the time to properly test this PR. Anyone feel free to pick it up from here if needed.