Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isImage helper with file signatures #334

Closed
wants to merge 1 commit into from
Closed

Update isImage helper with file signatures #334

wants to merge 1 commit into from

Conversation

faupol3
Copy link
Contributor

@faupol3 faupol3 commented Nov 5, 2021

Description

The isImage helper function depends on the mime type and in certain cases it doesn't work as expected. See related issues.
To overcome this issues, using file signature inspection is proposed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

I haven't worked with JS for a while and haven't had the time to properly test this PR. Anyone feel free to pick it up from here if needed.

@faupol3 faupol3 closed this by deleting the head repository Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

initialFiles doesn't work in dialog initialFiles do not displayed
1 participant