Keep the regex completely in the RegexCollection classes #39
JorgeAnzola
started this conversation in
Ideas
Replies: 1 comment
-
Thank you for the kind words! Will need sometime to analyze this and give some fruitful feedback. Sounds like a big impact but will see how to reduce it if possible. FYI, the Regex repository is in the process of being ripped out of here and into its own package. I'm using this specifically in https://github.com/YorCreative/Laravel-Scanator and currently requiring this entire scrubber package when it only needs the regex repository. This scrubber and the Scanator will share the regex repository package. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
First of all thanks for this package! it has been super useful. And secondly, I'm not a regex expert by any means so please correct me of discard this discussion if you don't considerate it relevant 😄 with that said:
I've removed the hardcoded delimiters (
~
and~i
) you had in src/Repositories/RegexRepository.php. I'm not sure what's the impact of this (besides having to change all the Regex classes and of course being a breaking change for people with custom Regex.The thing is that with this change, I'm able to use this regex, for example:
With in my case, it allows me to achieve this result in my logs
Which is something I need.
I'm referring to this commit.
PS: please ignore the work around I have in my fork for the password, I'll open another discussion for that.
Cheers!
Beta Was this translation helpful? Give feedback.
All reactions