fix(UpdateHandler): prepare to next doryphore release #1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| <?php | ||
|
|
||
| namespace YesWiki\Benevolat; | ||
|
|
||
| use YesWiki\Core\YesWikiAction; | ||
|
|
||
| class UpdateAction__ extends YesWikiAction | ||
| { | ||
| public function run() | ||
| { | ||
| if (!$this->isWikiHibernated() | ||
| && $this->wiki->UserIsAdmin() | ||
| && !empty($_GET['action']) | ||
| && $_GET['action'] === 'post_install' | ||
| ) { | ||
| $version = $this->params->get('yeswiki_version'); | ||
| if (!is_string($version)) { | ||
| $version = ''; | ||
| } | ||
| $release = $this->params->get('yeswiki_release'); | ||
| if (!is_string($release)) { | ||
| $release = ''; | ||
| } | ||
| $matches = []; | ||
| if ( | ||
| $version !== 'doryphore' | ||
| || !preg_match("/^(\d+)\.(\d+)\.(\d+)\$/", $release, $matches) | ||
| || intval($matches[1]) > 4 | ||
| || ( | ||
| intval($matches[1]) === 4 | ||
| && ( | ||
| intval($matches[2]) > 4 | ||
| || ( | ||
| intval($matches[2]) === 4 | ||
| && intval($matches[3]) > 4 | ||
| ) | ||
| ) | ||
| ) | ||
| ) { | ||
| $anchor = '<span class="update-hint">' . _t('UPDATE_ADMIN_PAGES_HINT') . '</span><br />'; | ||
| $this->output = str_replace( | ||
| $anchor, | ||
| <<<HTML | ||
| $anchor | ||
| <br/> | ||
| {$this->wiki->render('@benevolat/update-handler.twig', [])} | ||
| HTML, | ||
| $this->output | ||
| ); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| } | ||
|
There was a problem hiding this comment. il vaut mieux pas intervenir sur la page de post install, les migrations ont été créées pour etre lancées en fin d'install et maj, afin d'eviter des clics qui sont parfois oubliés par les usager.es et c'est pas forcement le bon endroit pour rajouter des boutons car tres peu visibles |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passer par un handler pour gérer la post-install est un peu "bancal" : si l'usagere ne lit pas la doc, elle ne connait pas l'existence de ce handler, et ne pourra pas finaliser la mise a jour de son yeswiki.
Je pense que ce serait mieux de ne pas permettre de choisir ses noms de pages, mais d'avoir une convention de nommage des pages ou on est presque surs que personne ne reprend ses nom et le les creer directement dans une migration.
(dans les versions futures de yeswiki on pourra sans doute reserver des routes comme pour les api)