Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure metadata from formatting is saved to disk #120

Closed
ckmah opened this issue Apr 21, 2024 · 4 comments
Closed

make sure metadata from formatting is saved to disk #120

ckmah opened this issue Apr 21, 2024 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@ckmah
Copy link
Collaborator

ckmah commented Apr 21, 2024

Metadata such as indexing columns generated as columns in spatialdata shapes are ignored when written to file using SpatialData.write() in version spatialdata==0.0.15. For now bento-tools will also reindex when loading data with bt.io.read_zarr().

Solution may be as simple as upgrading to spatialdata>=0.1.0.

@ckmah ckmah added the bug Something isn't working label Apr 21, 2024
@ckmah
Copy link
Collaborator Author

ckmah commented Apr 23, 2024

Looks like this is an open issue scverse/spatialdata#311 that still needs to be addressed scverse/spatialdata#293. Could also migrate all our annotations to Table elements and retrieve with get_values() instead but will be a significant refactor.

@LucaMarconato
Copy link

scverse/spatialdata#542 will solve the issue of columns lost when saving shapes.

@LucaMarconato
Copy link

The linked PR is now ready 😊

@ckmah ckmah added this to the v2.1.3 milestone Sep 10, 2024
@ckmah
Copy link
Collaborator Author

ckmah commented Sep 10, 2024

closed by #149

@ckmah ckmah closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants