From ffbe7b03158040b5d3a35d6497dcbec74169cc17 Mon Sep 17 00:00:00 2001 From: Yang-Yongzhi Date: Fri, 20 Sep 2024 15:30:00 +0800 Subject: [PATCH] Fix orch stuch when removing vlan member (#3294) What I did ignore the returned value of setPortPvid() --- orchagent/portsorch.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/orchagent/portsorch.cpp b/orchagent/portsorch.cpp index ba5336b063..d3e85deabc 100644 --- a/orchagent/portsorch.cpp +++ b/orchagent/portsorch.cpp @@ -6757,10 +6757,7 @@ bool PortsOrch::removeVlanMember(Port &vlan, Port &port, string end_point_ip) /* Restore to default pvid if this port joined this VLAN in untagged mode previously */ if (sai_tagging_mode == SAI_VLAN_TAGGING_MODE_UNTAGGED) { - if (!setPortPvid(port, DEFAULT_PORT_VLAN_ID)) - { - return false; - } + setPortPvid(port, DEFAULT_PORT_VLAN_ID); } m_portList[port.m_alias] = port;