Skip to content

Some resources are not created as models #6

Open
Denis-Alexeev opened this issue May 25, 2022 · 1 comment · May be fixed by #7
Open

Some resources are not created as models #6

Denis-Alexeev opened this issue May 25, 2022 · 1 comment · May be fixed by #7
Assignees
Labels
bug Something isn't working

Comments

@Denis-Alexeev
Copy link

Describe the bug
Some of models are not created because of similar child and and parrent names of different resources.

2022-05-25 15:11:03 - RMG - [14] Scanning: /redfish/v1/Chassis/Baseboard/Sensors parent is Element - ChassisCollectionChassis
2022-05-25 15:11:04 - RMG - [15] Scanning: /redfish/v1/Chassis/Baseboard/Thermal parent is Element - ChassisCollectionChassis
2022-05-25 15:11:06 - RMG - [16] Scanning: /redfish/v1/Chassis/VEGMAN_N110_Server parent is Collection - ChassisCollection
2022-05-25 15:11:08 - RMG - [16] Scanning: /redfish/v1/Chassis/VEGMAN_N110_Server/Power parent is Element - ChassisCollectionChassis
2022-05-25 15:11:11 - RMG - [16] Scanning: /redfish/v1/Chassis/VEGMAN_N110_Server/Sensors parent is Element - ChassisCollectionChassis
2022-05-25 15:11:12 - RMG - [16] Scanning: /redfish/v1/Chassis/VEGMAN_N110_Server/Sensors/PSU1_Input_Current parent is Collection - ChassisSensorCollection

Resource /redfish/v1/Chassis/Baseboard/Sensors was created with parent Element - ChassisCollectionChassis
But /redfish/v1/Chassis/VEGMAN_N110_Server/Sensors with parentElement - ChassisCollectionChassis was not created. Neither did all its children.

Expected behavior
redfish/v1/Chassis/VEGMAN_N110_Server/Sensors and its children are created.

Environment (please complete the following information):

  • OS: Mac
  • Python version: 3.10
  • Sebastes version: 0.1.4
  • Target device: BMC of Vegman N110 with firmware 1.5
@Shooshp
Copy link
Member

Shooshp commented Jun 6, 2022

Basic investigation - some parent resources have children with the same names but different models. I am not sure that it is ok according to Redfish or OpenAPI standards.
Simplest solution in my opinion is to introduce one more criteria for model equality (hash or frozen set of model field names for example). Also we need to update model names to prevent conflicts during scripts \ imports creation.

@rustam-python rustam-python linked a pull request Jun 9, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants