From 1f17adbb364bd0ebae591da975871a6788ab43da Mon Sep 17 00:00:00 2001 From: "Rifqi Alfi/IAB(YA)" Date: Tue, 2 Apr 2024 12:42:24 +0700 Subject: [PATCH] apply review feedback --- src/axolotl/utils/callbacks/vessl_.py | 2 ++ src/axolotl/utils/vessl_.py | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/axolotl/utils/callbacks/vessl_.py b/src/axolotl/utils/callbacks/vessl_.py index e68da3c68c..054f94cc4c 100644 --- a/src/axolotl/utils/callbacks/vessl_.py +++ b/src/axolotl/utils/callbacks/vessl_.py @@ -23,5 +23,7 @@ def on_log( logs: Dict[str, float], **kwargs # pylint: disable=unused-argument ): + # is_world_process_zero: Whether or not this process is the global main process (when training in a + # distributed fashion on several machines, this is only going to be `True` for one process). if state.is_world_process_zero: vessl.log(logs, state.global_step) diff --git a/src/axolotl/utils/vessl_.py b/src/axolotl/utils/vessl_.py index 346a6d2281..ff4af9de9c 100644 --- a/src/axolotl/utils/vessl_.py +++ b/src/axolotl/utils/vessl_.py @@ -6,8 +6,9 @@ def setup_vessl_env_vars(cfg: DictDefault): - # VESSL_RUN_INITIAL_CONFIG is a variable that contain path to - # default credential inside a VESSL Run + # VESSL_RUN_INITIAL_CONFIG is a variable that contain path to default credential inside a VESSL Run. + # Currently there is no docs regarding this variable, but it exists inside the container. + # Ref: https://screen.yanolja.in/lrTGow4Pr8eXhAai.png credential_path = os.environ.get("VESSL_RUN_INITIAL_CONFIG") if credential_path and not cfg.vessl_credential_path: cfg.vessl_credential_path = credential_path