Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor is almost totally transparent #3987

Closed
stdedos opened this issue Sep 4, 2023 · 18 comments
Closed

Monitor is almost totally transparent #3987

stdedos opened this issue Sep 4, 2023 · 18 comments
Labels
bug Something isn't working

Comments

@stdedos
Copy link
Collaborator

stdedos commented Sep 4, 2023

Describe the bug

image

To Reproduce

"Xpra-x86_64_6.0-r34134\xpra_cmd" shadow ssh://user@ip/1 --ssh="plink -ssh -agent" --modal-windows=no --desktop-scaling=1.25 --headerbar=off --title="@title@ on @@/@server-display@" --start="nohup systemd-inhibit --what=handle-lid-switch sleep 1d >/dev/null 2>&1 & inhibit_pid=$ ; xpra xwait ; kill -9 $inhibit_pid ; nohup systemd-inhibit --what=handle-lid-switch sleep 5m >/dev/null 2>&1 &" --key-shortcut=Shift+F2:toggle_pointer_grab --border=#FF5733,5 --microphone=off --speaker=off --webcam=no --pulseaudio=no

XPRA_EXECUTABLE=Xpra-x86_64_6.0-r34134

Note: GDK_WIN32_DISABLE_HIDPI is ignored due to preset
      DPI awareness settings in user settings or application
      manifest, DPI awareness is still enabled.2023-09-04 22:57:18,148 Xpra GTK3 client version 6.0-r34134 (g1e3ef8977) beta
2023-09-04 22:57:18,163  running on Microsoft Windows
2023-09-04 22:57:18,163  cpython 3.11
2023-09-04 22:57:21,899 GStreamer version 1.22.5
2023-09-04 22:57:22,068 created named pipe 'Xpra\\31248'
2023-09-04 22:57:22,291 Error setting up the pipeline:
2023-09-04 22:57:22,291  gst_parse_error: could not link decoder to sink (3)
2023-09-04 22:57:22,291  GStreamer pipeline for:
2023-09-04 22:57:22,291   appsrc name=src emit-signals=1 block=0 is-live=1 do-timestamp=1 stream-type=0 format=2 caps=video/x-h264,width=128,height=128,profile=(string)main,stream-format=(string)byte-stream,alignment=(string)au ! \
2023-09-04 22:57:22,291   d3d11h264dec name=decoder ! \
2023-09-04 22:57:22,292   appsink name=sink emit-signals=1 max-buffers=10 drop=false sync=false async=true qos=false caps=video/x-raw,width=128,height=128,format=(string)I420
2023-09-04 22:57:22,292 Error creating context h264 128x128 YUV420P
2023-09-04 22:57:22,292 gstreamer: h264 decoding failed: failed to setup gstreamer pipeline
2023-09-04 22:57:22,297 keyboard layout 'United States - English' : 'us' (0x409)
2023-09-04 22:57:22,787 Unable to import OpenGL.arrays.numpymodule.NumpyHandler: No numpy module present:

IMPORTANT: PLEASE READ THIS FOR ADVICE ON HOW TO SOLVE THIS ISSUE!

Importing the numpy C-extensions failed. This error can happen for
many reasons, often due to issues with your setup or how NumPy was
installed.

We have compiled some common reasons and troubleshooting tips at:

    https://numpy.org/devdocs/user/troubleshooting-importerror.html

Please note and check the following:

  * The Python version is: Python3.11 from "\xpra\Xpra-x86_64_6.0-r34134\Xpra_cmd.exe"
  * The NumPy version is: "1.25.2"

and make sure that they are the versions you expect.
Please carefully study the documentation linked above for further help.

Original error was: DLL load failed while importing _multiarray_umath: Δεν ήταν δυνατό να εντοπιστεί η καθορισμένη λειτ. μονάδα.

2023-09-04 22:57:22,792 OpenGL enabled on 'NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2'

System Information (please complete the following information):

  • Server OS: Ubuntu 20.04.5 LTS
  • Client OS: Microsoft Windows [Version 10.0.18363.836]
  • Xpra Server Version (see above)
  • Xpra Client Version (see above)

Additional context
Add any other context about the problem here.
Please see "reporting bugs" in the wiki section.

@stdedos stdedos added the bug Something isn't working label Sep 4, 2023
@stdedos stdedos changed the title Monitor is totally transparent Monitor is almost totally transparent Sep 4, 2023
@stdedos
Copy link
Collaborator Author

stdedos commented Sep 10, 2023

Still happens in

"Xpra-x86_64_6.0-r34211\xpra_cmd" shadow ssh://user@ip/1 --ssh="plink -ssh -agent" --modal-windows=no --desktop-scaling=1.25 --headerbar=off --title="@title@ on @@/@server-display@" --start="nohup systemd-inhibit --what=handle-lid-switch sleep 1d >/dev/null 2>&1 & inhibit_pid=$ ; xpra xwait ; kill -9 $inhibit_pid ; nohup systemd-inhibit --what=handle-lid-switch sleep 5m >/dev/null 2>&1 &" --key-shortcut=Shift+F2:toggle_pointer_grab --border=#FF5733,5 --microphone=off --speaker=off --webcam=no --pulseaudio=no

XPRA_EXECUTABLE=Xpra-x86_64_6.0-r34211

Note: GDK_WIN32_DISABLE_HIDPI is ignored due to preset
      DPI awareness settings in user settings or application
      manifest, DPI awareness is still enabled.2023-09-10 21:52:37,460 Xpra GTK3 client version 6.0-r34211 (g8b134915e) beta
2023-09-10 21:52:37,477  running on Microsoft Windows
2023-09-10 21:52:37,477  cpython 3.11
2023-09-10 21:52:40,467 GStreamer version 1.22.5
2023-09-10 21:52:40,618 created named pipe 'Xpra\\26108'
2023-09-10 21:52:40,684 Error importing dec_avif (avif decoder)
2023-09-10 21:52:40,685  DLL load failed while importing decoder: Δεν ήταν δυνατό να εντοπιστεί η καθορισμένη λειτ. μονάδα.
2023-09-10 21:52:40,836 Error setting up the pipeline:
2023-09-10 21:52:40,836  gst_parse_error: could not link decoder to sink (3)
2023-09-10 21:52:40,836  GStreamer pipeline for:
2023-09-10 21:52:40,836   appsrc name=src emit-signals=1 block=0 is-live=1 do-timestamp=1 stream-type=0 format=2 caps=video/x-h264,width=128,height=128,profile=(string)main,stream-format=(string)byte-stream,alignment=(string)au ! \
2023-09-10 21:52:40,836   d3d11h264dec name=decoder ! \
2023-09-10 21:52:40,836   appsink name=sink emit-signals=1 max-buffers=10 drop=false sync=false async=true qos=false caps=video/x-raw,width=128,height=128,format=(string)I420
2023-09-10 21:52:40,837 Error creating context h264 128x128 YUV420P
2023-09-10 21:52:40,837 gstreamer: h264 decoding failed: failed to setup gstreamer pipeline
2023-09-10 21:52:40,842 keyboard layout 'United States - English' : 'us' (0x409)
2023-09-10 21:52:41,322 Unable to import OpenGL.arrays.numpymodule.NumpyHandler: No numpy module present: No module named 'numpy'
2023-09-10 21:52:41,327 OpenGL enabled on 'NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2'
2023-09-10 21:52:41,420  keyboard settings: layout=us
2023-09-10 21:52:41,424  desktop size is 4480x1516:
2023-09-10 21:52:41,425   Default (1185x401 mm - DPI: 96x96) workarea: 4480x1476
2023-09-10 21:52:41,425     Samsung C32JG5x  2560x1440 at    0x0    (697x392 mm - DPI: 93x93) workarea: 2560x1400
2023-09-10 21:52:41,425     LG IPS234        1920x1080 at 2560x436  (510x290 mm - DPI: 96x95) workarea: 1920x1040 at 2560x436
2023-09-10 21:52:41,426  upscaled to 125%, virtual screen size: 3584x1213
2023-09-10 21:52:41,426   Default (1185x401 mm - DPI: 77x77) workarea: 3584x1181
2023-09-10 21:52:41,426     Samsung C32JG5x  2048x1152 at    0x0    (697x392 mm - DPI: 75x75) workarea: 2048x1120
2023-09-10 21:52:41,427     LG IPS234        1536x864  at 2048x349  (510x290 mm - DPI: 76x76) workarea: 1536x832  at 2048x349
2023-09-10 21:52:48,475 enabled remote logging
2023-09-10 21:52:48,477 Xpra shadow server version 5.0
2023-09-10 21:52:48,477  remote desktop size is 1920x1200
2023-09-10 21:52:48,478   :1.0 (508x318 mm - DPI: 96x96) workarea: 1848x1173 at   72x27
2023-09-10 21:52:48,479     LGD eDP-1        (336x210 mm - DPI: 145x145)
2023-09-10 21:52:48,967 running, 1 windows
2023-09-10 21:52:55,497 server is not responding, drawing spinners over the windows
2023-09-10 21:52:55,748 server is OK again

Serverlog is similar to #3996

@totaam
Copy link
Collaborator

totaam commented Sep 11, 2023

Can you run with -d draw so we can see what type of screen update has transparency set?
What type of shadow server is this? X11? (it should probably say it)
Oh, and does the problem go away if you turn off opengl?

totaam added a commit that referenced this issue Sep 11, 2023
@stdedos
Copy link
Collaborator Author

stdedos commented Sep 16, 2023

"Xpra-x86_64_6.0-r34211\xpra_cmd" shadow ssh://user@ip/1 --ssh="plink -ssh -agent" --modal-windows=no --headerbar=off --source-start=gnome-keyring-daemon --title="@title@ on @@/@server-display@" -d draw --start="nohup systemd-inhibit --what=handle-lid-switch sleep 1d >/dev/null 2>&1 & inhibit_pid=\$! ; xpra xwait ; kill -9 \$inhibit_pid ; nohup systemd-inhibit --what=handle-lid-switch sleep 5m >/dev/null 2>&1 &" --microphone=off --speaker=off --webcam=no --pulseaudio=no --key-shortcut=Shift+F2:toggle_pointer_grab

XPRA_EXECUTABLE=Xpra-x86_64_6.0-r34211

Note: GDK_WIN32_DISABLE_HIDPI is ignored due to preset
      DPI awareness settings in user settings or application
      manifest, DPI awareness is still enabled.2023-09-16 20:02:21,811 debug enabled for xpra.client.mixins.window_manager / ('draw',)
2023-09-16 20:02:21,828 Xpra GTK3 client version 6.0-r34211 (g8b134915e) beta
2023-09-16 20:02:21,842  running on Microsoft Windows
2023-09-16 20:02:21,842  cpython 3.11
2023-09-16 20:02:23,684 GStreamer version 1.22.5
2023-09-16 20:02:23,799 created named pipe 'Xpra\\37816'
2023-09-16 20:02:23,835 Error importing dec_avif (avif decoder)
2023-09-16 20:02:23,835  DLL load failed while importing decoder: Δεν ήταν δυνατό να εντοπιστεί η καθορισμένη λειτ. μονάδα.
2023-09-16 20:02:23,965 Error setting up the pipeline:
2023-09-16 20:02:23,965  gst_parse_error: could not link decoder to sink (3)
2023-09-16 20:02:23,966  GStreamer pipeline for:
2023-09-16 20:02:23,966   appsrc name=src emit-signals=1 block=0 is-live=1 do-timestamp=1 stream-type=0 format=2 caps=video/x-h264,width=128,height=128,profile=(string)main,stream-format=(string)byte-stream,alignment=(string)au ! \
2023-09-16 20:02:23,966   d3d11h264dec name=decoder ! \
2023-09-16 20:02:23,967   appsink name=sink emit-signals=1 max-buffers=10 drop=false sync=false async=true qos=false caps=video/x-raw,width=128,height=128,format=(string)I420
2023-09-16 20:02:23,967 Error creating context h264 128x128 YUV420P
2023-09-16 20:02:23,968 gstreamer: h264 decoding failed: failed to setup gstreamer pipeline
2023-09-16 20:02:23,972 keyboard layout 'United States - English' : 'us' (0x409)
2023-09-16 20:02:24,450 Unable to import OpenGL.arrays.numpymodule.NumpyHandler: No numpy module present: No module named 'numpy'
2023-09-16 20:02:24,454 OpenGL enabled on 'NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2'
2023-09-16 20:02:24,540  keyboard settings: layout=us
2023-09-16 20:02:24,543  desktop size is 4480x1516:
2023-09-16 20:02:24,543   Default (1185x401 mm - DPI: 96x96) workarea: 4480x1476
2023-09-16 20:02:24,544     Samsung C32JG5x  2560x1440 at    0x0    (697x392 mm - DPI: 93x93) workarea: 2560x1400
2023-09-16 20:02:24,544     LG IPS234        1920x1080 at 2560x436  (510x290 mm - DPI: 96x95) workarea: 1920x1040 at 2560x436
2023-09-16 20:02:30,192 enabled remote logging
2023-09-16 20:02:30,193 Xpra shadow server version 5.0
2023-09-16 20:02:30,194  remote desktop size is 1920x1200
2023-09-16 20:02:30,194   :1.0 (499x312 mm - DPI: 98x98) workarea: 1848x1173 at   72x27
2023-09-16 20:02:30,195     LGD eDP-1        (336x210 mm - DPI: 145x145)
2023-09-16 20:02:30,667 running, 1 windows
2023-09-16 20:02:30,866 process_draw:  343876    bytes for window   1, sequence        1, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'quality': 100, 'window-size': (1920, 1200)})
2023-09-16 20:02:30,893 sending ack: ('damage-sequence', 1, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:30,919 process_draw:  343876    bytes for window   1, sequence        2, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'quality': 100, 'window-size': (1920, 1200)})
2023-09-16 20:02:30,936 sending ack: ('damage-sequence', 2, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:30,983 process_draw:  341914    bytes for window   1, sequence        3, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'quality': 100, 'window-size': (1920, 1200)})
2023-09-16 20:02:31,000 sending ack: ('damage-sequence', 3, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:31,072 process_draw:  341914    bytes for window   1, sequence        4, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'quality': 100, 'window-size': (1920, 1200)})
2023-09-16 20:02:31,089 sending ack: ('damage-sequence', 4, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:31,167 process_draw:  341914    bytes for window   1, sequence        5, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'quality': 100, 'window-size': (1920, 1200)})
2023-09-16 20:02:31,185 sending ack: ('damage-sequence', 5, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:31,219 process_draw:  341914    bytes for window   1, sequence        6, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'quality': 100, 'window-size': (1920, 1200)})
2023-09-16 20:02:31,237 sending ack: ('damage-sequence', 6, 1, 1920, 1200, 15000, '')
2023-09-16 20:02:31,351 process_draw:  341914    bytes for window   1, sequence        7, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'quality': 100, 'window-size': (1920, 1200)})
2023-09-16 20:02:31,369 sending ack: ('damage-sequence', 7, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:31,419 process_draw:  342046    bytes for window   1, sequence        8, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'quality': 100, 'window-size': (1920, 1200)})
2023-09-16 20:02:31,436 sending ack: ('damage-sequence', 8, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:31,559 process_draw:  342046    bytes for window   1, sequence        9, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'quality': 100, 'window-size': (1920, 1200)})
2023-09-16 20:02:31,576 sending ack: ('damage-sequence', 9, 1, 1920, 1200, 15000, '')
2023-09-16 20:02:31,656 process_draw:  342046    bytes for window   1, sequence       10, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'quality': 100, 'window-size': (1920, 1200)})
2023-09-16 20:02:31,673 sending ack: ('damage-sequence', 10, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:31,847 process_draw:  342652    bytes for window   1, sequence       11, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'quality': 100, 'window-size': (1920, 1200)})
2023-09-16 20:02:31,867 sending ack: ('damage-sequence', 11, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:32,124 process_draw:  226680    bytes for window   1, sequence       12, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'subsampling': 'YUV420P', 'quality': 68, 'window-size': (1920, 1200)})
2023-09-16 20:02:32,143 sending ack: ('damage-sequence', 12, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:32,204 process_draw:  206946    bytes for window   1, sequence       13, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'subsampling': 'YUV420P', 'quality': 63, 'window-size': (1920, 1200)})
2023-09-16 20:02:32,216 sending ack: ('damage-sequence', 13, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:32,236 process_draw:  172520    bytes for window   1, sequence       14, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'subsampling': 'YUV420P', 'quality': 63, 'window-size': (1920, 1200)})
2023-09-16 20:02:32,247 sending ack: ('damage-sequence', 14, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:32,306 process_draw:  170938    bytes for window   1, sequence       15, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'subsampling': 'YUV420P', 'quality': 63, 'window-size': (1920, 1200)})
2023-09-16 20:02:32,318 sending ack: ('damage-sequence', 15, 1, 1920, 1200, 15000, '')
2023-09-16 20:02:32,359 process_draw:  170778    bytes for window   1, sequence       16, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'subsampling': 'YUV420P', 'quality': 63, 'window-size': (1920, 1200)})
2023-09-16 20:02:32,369 sending ack: ('damage-sequence', 16, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:32,419 process_draw:  201660    bytes for window   1, sequence       17, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'subsampling': 'YUV420P', 'quality': 63, 'window-size': (1920, 1200)})
2023-09-16 20:02:32,431 sending ack: ('damage-sequence', 17, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:32,493 process_draw:  202652    bytes for window   1, sequence       18, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'subsampling': 'YUV420P', 'quality': 63, 'window-size': (1920, 1200)})
2023-09-16 20:02:32,504 sending ack: ('damage-sequence', 18, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:32,541 process_draw:  203410    bytes for window   1, sequence       19, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'subsampling': 'YUV420P', 'quality': 63, 'window-size': (1920, 1200)})
2023-09-16 20:02:32,553 sending ack: ('damage-sequence', 19, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:32,613 process_draw:  203564    bytes for window   1, sequence       20, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'subsampling': 'YUV420P', 'quality': 63, 'window-size': (1920, 1200)})
2023-09-16 20:02:32,624 sending ack: ('damage-sequence', 20, 1, 1920, 1200, 0, '')
2023-09-16 20:02:32,652 process_draw:  203358    bytes for window   1, sequence       21, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'subsampling': 'YUV420P', 'quality': 63, 'window-size': (1920, 1200)})
2023-09-16 20:02:32,662 sending ack: ('damage-sequence', 21, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:32,723 process_draw:  203886    bytes for window   1, sequence       22, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'subsampling': 'YUV420P', 'quality': 63, 'window-size': (1920, 1200)})
2023-09-16 20:02:32,735 sending ack: ('damage-sequence', 22, 1, 1920, 1200, 0, '')
2023-09-16 20:02:32,825 process_draw:  203926    bytes for window   1, sequence       23, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'subsampling': 'YUV420P', 'quality': 63, 'window-size': (1920, 1200)})
2023-09-16 20:02:32,837 sending ack: ('damage-sequence', 23, 1, 1920, 1200, 16000, '')
2023-09-16 20:02:32,892 process_draw:  204100    bytes for window   1, sequence       24, 1920x1200 at    0,0    using   webp encoding with options=typedict({'rgb_format': 'BGRX', 'subsampling': 'YUV420P', 'quality': 63, 'window-size': (1920, 1200)})
2023-09-16 20:02:32,902 sending ack: ('damage-sequence', 24, 1, 1920, 1200, 15000, '')
2023-09-16 20:02:33,829 window-close event on desktop or shadow window, disconnecting

--opengl=no works perfectly

@totaam
Copy link
Collaborator

totaam commented Sep 17, 2023

How strange!
These are webp screen updates clearly specifying BGRX as pixel format, and some are subsampled using YUV420P. YUV420P doesn't even carry an alpha channel at all - unlike BGRX where X represents the unused alpha channel.

These should never have any transparency applied when painting.
The window's OpenGL backend should be using RGB8 as pixel format, not RGBA8.
And indeed, this is exactly what I see here when I test on Linux and MS Windows.

As an aside, it seems that the SVGA3D VirtualBox driver is now capable of running xpra's opengl rendering, so this is no longer blacklisted: 5c0811a
I will try on bare metal MS Windows next.

Can you confirm that this problem is limited to webp by running with --encodings=-webp?

@stdedos
Copy link
Collaborator Author

stdedos commented Sep 19, 2023

Can you confirm that this problem is limited to webp by running with --encodings=-webp?

I don't think so 😕

"Xpra-x86_64_6.0-r34211\xpra_cmd" shadow ssh://user@ip/1 --ssh="plink -ssh -agent" --modal-windows=no --headerbar=off --source-start=gnome-keyring-daemon --title="@title@ on @@/@server-display@" --encodings=-webp --start="nohup systemd-inhibit --what=handle-lid-switch sleep 1d >/dev/null 2>&1 & inhibit_pid=\$! ; xpra xwait ; kill -9 \$inhibit_pid ; nohup systemd-inhibit --what=handle-lid-switch sleep 5m >/dev/null 2>&1 &" --microphone=off --speaker=off --webcam=no --pulseaudio=no --key-shortcut=Shift+F2:toggle_pointer_grab

Screenshot-Xpra_cmd_2023-09-19_22-37-44

However, server still has this too late to set modules error, and apt-get is not offering any updates (v5.0.2-r0)

I do have the beta focal InRelease activated 😕

@totaam
Copy link
Collaborator

totaam commented Sep 20, 2023

@stdedos do you have the full too late to set modules backtrace from a v5.0.2 env?
(perhaps this has something to do with it - I can't imagine how, but worth fixing nonetheless)

@stdedos
Copy link
Collaborator Author

stdedos commented Sep 20, 2023

2023-09-19 22:33:38,604 no uinput module (not usually needed)
2023-09-19 22:33:38,797 serving html content from '/usr/share/xpra/www'
2023-09-19 22:33:38,797 wrote pid 2715546 to '/run/user/1000/xpra/1/server.pid'
2023-09-19 22:33:38,897 created unix domain socket '/run/user/1000/xpra/main-pc-1'
2023-09-19 22:33:38,897 cannot create group socket '/run/xpra/main-pc-1'
2023-09-19 22:33:38,897  [Errno 13] Permission denied
2023-09-19 22:33:38,897 created unix domain socket '/home/u/.xpra/main-pc-1'
2023-09-19 22:33:38,898 created unix domain socket '/run/user/1000/xpra/1/socket'
2023-09-19 22:33:38,915 python-zeroconf: '::' IPv6 loopback address is not supported
2023-09-19 22:33:38,916 notification forwarding is not available
2023-09-19 22:33:38,916  the interface is already claimed
2023-09-19 22:33:38,949 capture using XImageCapture
2023-09-19 22:33:38,962 xpra is ready.
2023-09-19 22:33:38,962 xpra shadow server version 5.0.2-r0
2023-09-19 22:33:38,999  uid=1000 (u), gid=1000 (u)
2023-09-19 22:33:39,000  running with pid 2715546 on Linux Ubuntu 20.04 focal
2023-09-19 22:33:39,000 watching for applications menu changes in:
2023-09-19 22:33:39,000  '/home/u/.local/share/flatpak/exports/share/applications'
2023-09-19 22:33:39,000  '/var/lib/flatpak/exports/share/applications'
2023-09-19 22:33:39,000  '/usr/share/applications'
2023-09-19 22:33:39,000  '/var/lib/snapd/desktop/applications'
2023-09-19 22:33:39,000  on X11 display :1 of size 1920x1200
2023-09-19 22:33:39,096 GStreamer version 1.16.3
2023-09-19 22:33:39,134 New socket connection received
2023-09-19 22:33:39,134  on '/home/u/.xpra/main-pc-1'
2023-09-19 22:33:39,237 New socket connection received
2023-09-19 22:33:39,238  on '/home/u/.xpra/main-pc-1'
2023-09-19 22:33:39,243 Handshake complete; enabling connection
2023-09-19 22:33:39,365 Python/GTK3 Microsoft Windows aero client version 6.0
2023-09-19 22:33:39,366  connected as 'u'
2023-09-19 22:33:39,366  OpenGL is enabled with NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2
2023-09-19 22:33:39,371 shadow server: setting default keymap translation
2023-09-19 22:33:39,432  client root window size is 4480x1516
2023-09-19 22:33:39,476 client   1 @06.390 Xpra shadow server version 5.0
2023-09-19 22:33:39,492 client   1 @06.390  remote desktop size is 1920x1200
2023-09-19 22:33:39,492 client   1 @06.390   :1.0 (508x318 mm - DPI: 96x96) workarea: 1848x1173 at   72x27  
2023-09-19 22:33:39,492 client   1 @06.390     LGD eDP-1        (336x210 mm - DPI: 145x145)
2023-09-19 22:33:39,925 shadow server: setting default keymap translation
2023-09-19 22:33:40,019 client   1 @06.890 running, 1 windows
2023-09-19 22:33:40,535 the keymap has been changed: us,gr,us
2023-09-19 22:33:41,381 loaded 76 start menu entries from 13 sub-menus in 2.4 seconds
2023-09-19 22:33:41,984 Warning: not adding duplicate printer 'PDFCreator'
2023-09-19 22:33:41,985 Warning: not adding duplicate printer 'OneNote (Desktop)'
2023-09-19 22:33:46,551 printer forwarding enabled using postscript and pdf
2023-09-19 22:33:46,553 Error: video helper modules have already been initialized
2023-09-19 22:33:46,553 from:
2023-09-19 22:33:46,553    File "/usr/bin/xpra", line 17, in <module>
    sys.exit(main(sys.argv[0], sys.argv))
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/scripts/main.py", line 121, in main
    return run_mode(script_file, cmdline, err, options, args, mode, defaults)
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/scripts/main.py", line 455, in run_mode
    return do_run_mode(script_file, cmdline, error_cb, options, args, mode, defaults)
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/scripts/main.py", line 520, in do_run_mode
    return run_server(script_file, cmdline, error_cb, options, args, mode, defaults)
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/scripts/main.py", line 1919, in run_server
    return do_run_server(script_file, cmdline, error_cb, options, args, mode, str(display or ""), defaults)
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/scripts/server.py", line 724, in do_run_server
    return _do_run_server(script_file, cmdline,
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/scripts/server.py", line 1533, in _do_run_server
    r = app.run()
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/server/shadow/shadow_server_base.py", line 80, in run
    return super().run()
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/server/server_core.py", line 460, in run
    self.do_run()
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/server/gtk_server_base.py", line 140, in do_run
    Gtk.main()
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 1632, in main
    return _Gtk_main(*args, **kwargs)
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/server/server_core.py", line 2245, in call_hello_oked
    self.hello_oked(proto, c, auth_caps)
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/server/server_base.py", line 406, in hello_oked
    ss = cc_class(proto, drop_client,
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/server/source/client_connection_factory.py", line 108, in __init__
    c.init_state(self)
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/server/source/encodings.py", line 69, in init_state
    self.video_helper = getVideoHelper().clone()
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/codecs/video_helper.py", line 204, in clone
    self.init()
2023-09-19 22:33:46,553    File "/usr/lib/python3/dist-packages/xpra/codecs/video_helper.py", line 254, in init
    self._init_from.append(traceback.format_stack())
2023-09-19 22:33:46,553 Error during threaded setup of <class 'xpra.server.mixins.encoding.EncodingServer'>
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/xpra/server/server_base.py", line 190, in threaded_init
    c.threaded_setup(self)
  File "/usr/lib/python3/dist-packages/xpra/server/mixins/encoding.py", line 96, in threaded_setup
    getVideoHelper().set_modules(video_encoders=self.video_encoders, csc_modules=self.csc_modules)
  File "/usr/lib/python3/dist-packages/xpra/codecs/video_helper.py", line 173, in set_modules
    raise RuntimeError("too late to set modules, the helper is already initialized")
RuntimeError: too late to set modules, the helper is already initialized
2023-09-19 22:33:46,557 31.1GB of system memory
2023-09-19 22:33:46,659 some GStreamer elements are missing or unavailable on this system:
2023-09-19 22:33:46,659  amfh264enc, amfh265enc
2023-09-19 22:33:47,069 OpenGL is supported on display ':1'
2023-09-19 22:33:47,069  using 'Mesa Intel(R) UHD Graphics (TGL GT1)' renderer
2023-09-19 22:33:47,075 started command `nohup systemd-inhibit --what=handle-lid-switch sleep 1d >/dev/null 2>&1 & inhibit_pid=$! ; xpra xwait ; kill -9 $inhibit_pid ; nohup systemd-inhibit --what=handle-lid-switch sleep 5m >/dev/null 2>&1 &` with pid 2715871
2023-09-19 22:33:47,076  automatic picture encoding enabled, also available:
2023-09-19 22:33:47,076   png, png/P, png/L, rgb24, rgb32, jpeg, jpega, scroll
0;1;31mFailed to inhibit: Access denied
2023-09-19 22:33:51,818 the keymap has been changed: us,gr,us
2023-09-19 22:34:01,496 client   1 @28.406 server is not responding, drawing spinners over the windows
2023-09-19 22:34:01,746 client   1 @28.672 server is OK again

@totaam
Copy link
Collaborator

totaam commented Sep 21, 2023

The too late to set modules, the helper is already initialized should be gone in v5.x as of 9205f59.
Good news: I can reproduce the transparency problem with VirtualBox now, something has changed - no idea what yet.
I should be able to fix it or figure out a workaround.

@stdedos
Copy link
Collaborator Author

stdedos commented Sep 21, 2023

The too late to set modules, the helper is already initialized should be gone in v5.x as of 9205f59.

Yeah; also tracked here #3996

ik 😕 "I'm afraid" something is happening with the beta repository. "Year(s) ago" every 5-10-15 commits there was a new xpra-beta coming up.

... but I didn't want to bring that up, since your overloading and de-commissioning and stuff ...

@totaam
Copy link
Collaborator

totaam commented Jan 29, 2024

New datapoint: in trying to force enable opengl acceleration in a virtualbox win10 VM (VBoxSVGA is still not working well enough - even with the new opengl backend: #2467), I ended up seeing a similar effect.

I have added the environment variable XPRA_OPENGL_ALWAYS_RGBA: set this to 1 to always use RGBA internal format for storing the window contents in GPU memory.
This is a waste of space and memory bandwidth since we know that most windows won't be using an alpha channel, but it seems that some buggy drivers will paint this unused alpha channel anyway, so it may be best to enable it then the upload functions will remember to set it to zero..
@stdedos does that help? (6.0-r35021 or later)

@stdedos
Copy link
Collaborator Author

stdedos commented Jan 29, 2024

I'll download it and test tonight 🖖

Hopefully all necessary parts are/will be uploaded (Windows Client and Ubuntu Server)

@totaam
Copy link
Collaborator

totaam commented Jan 29, 2024

Hopefully all necessary parts are/will be uploaded (Windows Client and Ubuntu Server)

The only part that's changed is the client side, and the new Windows client is available in ZIP and EXE formats.
Don't forget to set XPRA_OPENGL_ALWAYS_RGBA=1 - and maybe try without first, to ensure the bug is still present.

@stdedos
Copy link
Collaborator Author

stdedos commented Jan 29, 2024

Can't test 😢 #4109

@stdedos
Copy link
Collaborator Author

stdedos commented Jan 31, 2024

Ha. Talk about "magically closing bug".

It seems that I cannot replicate it 🙃

Something between 1e3ef89..4829278 (6.0-r35043) fixed it
(Just a couple .... 27ks of changes. but who's counting? 😅
https://github.com/Xpra-org/xpra/compare/1e3ef8977..48292788a?w=1)

@stdedos stdedos closed this as completed Jan 31, 2024
@totaam
Copy link
Collaborator

totaam commented Feb 1, 2024

Could also be a driver bug that's been fixed.
It really looks like painting an uninitialized (and unused) alpha channel.

@stdedos
Copy link
Collaborator Author

stdedos commented Feb 22, 2024

Idk how related they are, but btw:

image

That's with xpra\Xpra-x86_64_6.0-r35043\Xpra.exe (and r35164 too)

@totaam
Copy link
Collaborator

totaam commented Feb 23, 2024

Does XPRA_OPENGL_ALWAYS_RGBA make any difference?

@stdedos
Copy link
Collaborator Author

stdedos commented Feb 23, 2024

Sadly no

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants