Remove Dialog support? #191
Replies: 3 comments 1 reply
-
while this will be messed up if i add echo/printf formatting IN the json tha creates the menus ... I think i should LEAVE the dialog code but |
Beta Was this translation helpful? Give feedback.
-
5ac13ee this commit turns off the check for dialog menus basically ... i dont like not being able (note: i was gonig to maybe do bold/italics but since people have different terminal themes i never wanted to go nuts with colors ... say i make something yellow to stand out on a black background (normal text = white) ... WHAT if that user uses a light background color on the terminal ... say yellow text on a white bg wouldn't work |
Beta Was this translation helpful? Give feedback.
-
it maybe a bad idea but the little bit of "flash" i wanted to add to the echo menus i think i have now from the function "fancy_message" from the deb-get project I am not "un-arraying" the menus but I dont see myself going back to using Dialog AND Echo together |
Beta Was this translation helpful? Give feedback.
-
I am thinking of removing Dialog support .... keeping everything (the new array way of doing the menus, in case i want to bring it back down the road) and reintroducing formatting like bold and maybe (never did this) colors to the echo statements.
The problem would be the DIALOG menus would have say "${Bold} Foobar item ${reset}" as menu items instead of just "Foobar item" if i put the formatting in the arrays itself.
I could check for the menu item and (complete example) if say "[Sub-Menu]" is detected in the menu entry text, that is say ... blue or bold ... and that code is only in the echo type menu (KEEPING dialog support for an ncurses like experience)
Beta Was this translation helpful? Give feedback.
All reactions