-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic MVAU integration #1242
Draft
azizb-xlnx
wants to merge
25
commits into
dev
Choose a base branch
from
feature/mvau_dyn
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Dynamic MVAU integration #1242
+1,662
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove weights when using dynmaic MM
- Rename Weight input to inp_B - Use WDT as a flag to test dynamic mm
- rename weight to inp_B - conditional on weight initializer
- rename test node inputs for dynamic mm
- explicitly use weightDataType field to decide if this is dynamic MVAU
- if the MVAU node does not provide wdt, assume it has two inputs.
- These functions are specific to dynamic mm
- assume that the weight tensor is the same as the input tensor B
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To minimize changes, we overload the weight input of the existing MVAU superclass to serve as the second input for a dynamic MVAU. The specialized layer transform will instantiate the appropriate RTL subclass based on the presence of a weight initializer.