Attempt to parse object as JSON results in "JSON parse body failed" written to console #686
Comments
|
PETOSS-440 |
|
Thanks for raising an issue, a ticket has been created to track your request |
|
Hey @drew-r We have removed the unnecessary json parsing code in our latest xero-node v9.0.0. Please try our new version and let us know with any further issues. |
sangeet-joy-tw
pushed a commit
that referenced
this issue
Aug 29, 2024
********* Testing ************* Build from OAS 5.0.0 ## What's Changed * Bugfix #679 | createInvoiceAttachmentByFileName Create attachment but not correct content file * Bugfix #686 | Attempt to parse object as JSON results in JSON parse body failed written to console ## Breaking Change * Removed PageInfo metadata object and added pagination metadata object for select Api.Accounting endpoints * Added ultimate sub plans for Api.Accounting
sangeet-joy-tw
pushed a commit
that referenced
this issue
Aug 30, 2024
## What's Changed 2 * Bugfix #686 | Attempt to parse object as JSON results in "JSON parse body failed" written to 'console ouput' from `xero` org. [google](www.google.com)
sangeet-joy-tw
pushed a commit
that referenced
this issue
Aug 30, 2024
## What's Changed 2 * Bugfix #686 | Attempt to parse object as JSON results in "JSON parse body failed" written to 'console ouput' from `xero` org. [google](www.google.com)
sangeet-joy-tw
pushed a commit
that referenced
this issue
Aug 30, 2024
## What's Changed 2 * Bugfix #686 | Attempt to parse object as JSON results in "JSON parse body failed" written to 'console ouput' from `xero` org. [google](www.google.com)
sangeet-joy-tw
pushed a commit
that referenced
this issue
Aug 30, 2024
## What's Changed 2 * Bugfix #686 | Attempt to parse object as JSON results in "JSON parse body failed" written to 'console ouput' from `xero` org. [google](www.google.com)
sangeet-joy-tw
pushed a commit
that referenced
this issue
Aug 30, 2024
## What's Changed 2 * Bugfix #686 | Attempt to parse object as JSON results in "JSON parse body failed" written to 'console ouput' from `xero` org. [google](www.google.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SDK you're using (please complete the following information):
Version 5.1.0 but looks present in 6.0.0
Describe the bug
There is an attempt to parse what is already an object as JSON, which throws an error causing 'JSON parse body failed' to be written to the console.
To Reproduce
Call
getBankTransactionAttachmentsetc.Expected behavior
There is no attempt to JSON.parse & nothing is written to the console
It's not ideal for libraries to be writing to the console at all unless some verbosity/tracing is explicitly requested for example through a DEBUG env var
The text was updated successfully, but these errors were encountered: