New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wait_for #25

Open

Xasin opened this issue Jul 6, 2018 · 0 comments

Labels

fixme later MQTT

Contributor

Xasin commented Jul 6, 2018

See Reviewable comment in #22 by CyanRainNin:

According to comment above the block is optional.
So this blocks the main thread?
How about spawning a thread to handle setting a false/true fiber-variable and unregistering after timeout. When you return that the receiver can use .join if it is supposed to be blocking.

To avoid breaking existing code, you could do the above as a new wait_for_async method implementation

It's a good idea, definitely something for later!

Xasin added MQTT fixme later labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment