-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update references in CONTRIBUTING.md
#2832
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Emmanuel Ferdman <[email protected]>
WalkthroughThe changes in this pull request focus on updating the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
CONTRIBUTING.md (1)
135-135
: Minor grammar and typography improvementsConsider these refinements:
- Add a comma after "updates": "...latest updates, Since standalone mode..."
- Use an en dash for the time range: "wait 4–5 seconds" instead of "wait 4-5 seconds"
🧰 Tools
🪛 LanguageTool
[uncategorized] ~135-~135: Possible missing comma found.
Context: ...erally run against a docker instance of rippled which contains the latest updates. Sinc...(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~135-~135: If specifying a range, consider using an en dash instead of a hyphen.
Context: ...much faster rate than if we had to wait 4-5 seconds per transaction for the ledger ...(HYPHEN_TO_EN)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
CONTRIBUTING.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
CONTRIBUTING.md
[uncategorized] ~135-~135: Possible missing comma found.
Context: ...erally run against a docker instance of rippled which contains the latest updates. Sinc...
(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~135-~135: If specifying a range, consider using an en dash instead of a hyphen.
Context: ...much faster rate than if we had to wait 4-5 seconds per transaction for the ledger ...
(HYPHEN_TO_EN)
🔇 Additional comments (2)
CONTRIBUTING.md (2)
133-133
: LGTM! Path update aligns with testing conventions.
The updated path using .test.ts
extension follows modern TypeScript testing conventions.
139-139
: LGTM! Consistent path update for integration tests.
The path update maintains consistency with the test file naming convention.
High Level Overview of Change
PR updates the test references in
CONTRIBUTING.md
.Context of Change
Type of Change
Did you update HISTORY.md?
Test Plan