Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle ledger object does not expose OracleDocumentID field (Version: rippled-2.2.3) #5178

Open
pkcs8 opened this issue Nov 3, 2024 · 1 comment

Comments

@pkcs8
Copy link

pkcs8 commented Nov 3, 2024

Issue Description

OracleDocumentID is an important field for Oracle objects. It is a required field while creating a new Oracle, but rippled doesn't return this field when querying the ledger object via ledger_entry, account_objects and possibly other methods.

If OracleDocumentID is not discoverable via available methods, it would be difficult to delete the Oracle since OracleDelete transaction takes OracleDocumentID as a required parameter.

Steps to Reproduce

Fetch an Oracle object using ledger_entry command.

curl -H 'Content-Type: application/json' -d '{"method":"ledger_entry","params":[{"index":"28716548F718BE307D1492BABDF21C5D71CD8248F6D5FC591BE598E6BC6E2692","ledger_index":"validated"}]}' https://s1.ripple.com:51234/

Example: https://explorer.xrplf.org/entry/28716548F718BE307D1492BABDF21C5D71CD8248F6D5FC591BE598E6BC6E2692

Expected Result

Oracle object returned by rippled should contain OracleDocumentID field.

Actual Result

Oracle object returned by rippled does not contain OracleDocumentID field.

Environment

Using rippled-2.2.3.

Supporting Files

OracleDocumentID

@tequdev
Copy link
Contributor

tequdev commented Nov 4, 2024

OracleDocumentID seems to be missing from the Oracle object

LEDGER_ENTRY(ltORACLE, 0x0080, Oracle, ({
{sfOwner, soeREQUIRED},
{sfProvider, soeREQUIRED},
{sfPriceDataSeries, soeREQUIRED},
{sfAssetClass, soeREQUIRED},
{sfLastUpdateTime, soeREQUIRED},
{sfURI, soeOPTIONAL},
{sfOwnerNode, soeREQUIRED},
{sfPreviousTxnID, soeREQUIRED},
{sfPreviousTxnLgrSeq, soeREQUIRED},
}))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants