Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI with Azure Pipelines #48

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Set up CI with Azure Pipelines #48

wants to merge 6 commits into from

Conversation

ReidWeb
Copy link
Member

@ReidWeb ReidWeb commented May 12, 2019

No description provided.

@ReidWeb
Copy link
Member Author

ReidWeb commented May 12, 2019

Please do not accept yet

@ReidWeb ReidWeb force-pushed the ci/azure-pipelines branch from ab25031 to 662c781 Compare May 12, 2019 10:50
@matthewhillier
Copy link
Member

👍

@ReidWeb
Copy link
Member Author

ReidWeb commented May 12, 2019

Should be ready for acceptance once we get a passing build - configured baseline, and hooked in Jonathan's test DB.

I'll look to get a docker defined test db running at some pt, and bring in the code cov stats again

@ReidWeb
Copy link
Member Author

ReidWeb commented May 12, 2019

Sincerest apologies for the notification spam, not sure what caused that

matthewhillier and others added 3 commits May 17, 2019 12:44
- Updated Unit Tests to match
- Fixed Unit Test failures from updated character info
…ts/XIVStats-Gatherer-Java into ci/azure-pipelines

* 'ci/azure-pipelines' of github.com:XIVStats/XIVStats-Gatherer-Java:

* 'master' of github.com:XIVStats/XIVStats-Gatherer-Java:
  Fixed addition of DC name into World filed (#50)

# Conflicts:
#	src/test/resources/data/lodestone/Character-2256025.html
#	src/test/resources/data/lodestone/Character-22763008.html
@ReidWeb
Copy link
Member Author

ReidWeb commented Jun 15, 2019

@matthewhillier looking at an alternate CI (Travis), having an issue with one of the tests in this run, any speculation as to the cause?

@matthewhillier
Copy link
Member

Hey @ReidWeb - I think I found one test in my latest branch which had an overly-strict test against a live character (https://github.com/XIVStats/XIVStats-Gatherer-Java/pull/51/files#diff-38deaf8a51cc511381feab7299f7940cR97).

I've fixed in my branch, but you may need to replicate in yours or we'll need to merge in this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants