Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug: Correct labels of yaml files in labeled_data directory. #1487

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

birdflyi
Copy link
Contributor

@birdflyi birdflyi commented Jan 10, 2024

Fix #1484

Purpose

  • Fix miss counting bug: Add the untracked categories into its parent node index.yml label list.
  • Fix mixed counting bug: Change the 'Tech-N' label to match the default template: increase N from root node to leaf node based on depth.

Changes

Notes: *.yml files mentioned below do not including index.yml.

  • Fix miss counting bug in :technology`:

    • Add missing index.yml: `:technology/ai/generative_ai/infrastructure/index.yml .
    • Add 3rd depth :technology/ai/generative_ai/infrastructure/*.yml into :technology/ai/generative_ai/infrastructure/index.yml label list;
    • Add 3rd depth :technology/ai/generative_ai/application/*.yml into :technology/ai/generative_ai/application/index.yml label list.
    • Add 3rd depth :technology/ai/generative_ai/model/*.yml into :technology/ai/generative_ai/model/index.yml label list.
    • Add 3rd depth :technology/ai/generative_ai/tool/*.yml into :technology/ai/generative_ai/tool/index.yml label list.
  • Fix mixed counting bug in :technology:

    • Change 3rd depth leaf files :technology/ai/generative_ai/*/*.yml type to Tech-3
    • Change 3rd depth leaf files :technology/ai/generative_ai/*/index.yml type to Tech-2 to represent the categories in 2rd depth directories :technology/ai/generative_ai/*/
    • Change 2nd depth leaf files :technology/ai/large_language_model/index.yml type to Tech-1 to represent the categories in 1st depth directories :technology/ai/large_language_model/.
    • Add supported label type Tech-3 into label_data_utils.ts.

Default Settings

Current depth defination: The sub-directories :technology/* in [:technology](https://github.com/X-lab2017/open-digger/tree/master/labeled_data/technology) is 0th layer, and its label type is in the :technology/*/index.yml under it with the format type: Tech-0. The type level of subordinate files increases gradually by depth.

@open-digger-bot open-digger-bot bot added the kind/bug Category issues or prs related to bug. label Jan 10, 2024
@frank-zsy
Copy link
Contributor

I add some review comments about the label names and sub label which could also be applied to all other labels, can you modify the names and the labels.

@birdflyi
Copy link
Contributor Author

LGTM, I'll have a try~

@frank-zsy frank-zsy merged commit 7ad92a1 into X-lab2017:master Jan 11, 2024
1 check passed
@birdflyi birdflyi deleted the labeled_data_patch branch January 11, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
2 participants