feat: add issue comment TFIDF similarity metrics and issue comment Ja… #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @bifenglin , if this pr has not completed, you can convert it to draft PR |
…ccard similarity Signed-off-by: bifenglin <[email protected]>
xgdyp
reviewed
Apr 5, 2023
| @@ -15,6 +16,10 @@ def getRelatedUsers(config): | |||
| return related_users.getRelatedUsers(config) | |||
| def getAttention(config): | |||
| return attention.getAttention(config) | |||
| def getIssueCommentTFIDFSimilarity(config): | |||
There was a problem hiding this comment.
It seems that config has never been used
xgdyp
reviewed
Apr 5, 2023
| """ | ||
| TODO: get Selected Acotrs | ||
| """ | ||
| sql = 'SELECT DISTINCT(actor_id) FROM opensource.gh_events') |
There was a problem hiding this comment.
I think we can add a limit clause such as limit 10
There was a problem hiding this comment.
The function aims to find all users if have no selecting choice.
There was a problem hiding this comment.
DISTINCT selection from the whole table may lead to a OOM exception since the ClickHouse only has 128GB memory, we should definitely avoid this kind of SQL.
|
hi, I think this pr can be converted into a case in |
|
hi @bifenglin. I'm adding this to the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the metric about actors' comment TFIDF similarity and actors' Jaccard similarity.