From faf8dd4d3abf7cbaaae709dc25b2b48f040bfc26 Mon Sep 17 00:00:00 2001 From: John Renne Date: Wed, 7 Dec 2022 19:31:02 +0100 Subject: [PATCH 1/2] Updated node to 16 and removed deprecated method --- action.yml | 2 +- entrypoint.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/action.yml b/action.yml index 2b546e7..553c996 100644 --- a/action.yml +++ b/action.yml @@ -11,5 +11,5 @@ inputs: description: 'The full helm command to run (including helm)' required: false runs: - using: 'node12' + using: 'node16' main: 'main.js' diff --git a/entrypoint.sh b/entrypoint.sh index 5a436a5..52bd850 100644 --- a/entrypoint.sh +++ b/entrypoint.sh @@ -24,7 +24,7 @@ helm_output="${helm_output//'%'/'%25'}" helm_output="${helm_output//$'\n'/'%0A'}" helm_output="${helm_output//$'\r'/'%0D'}" -echo "::set-output name=helm_output::$helm_output" +echo "helm_output=$helm_output" >> $GITHUB_OUTPUT echo -e "\033[36mCleaning up: \033[0m" rm ./run.sh -Rf From 503eb17598929b9daece745b8e102237bc1502f3 Mon Sep 17 00:00:00 2001 From: John Renne Date: Thu, 8 Dec 2022 09:43:20 +0100 Subject: [PATCH 2/2] Processed Review --- entrypoint.sh | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/entrypoint.sh b/entrypoint.sh index 52bd850..11f4d46 100644 --- a/entrypoint.sh +++ b/entrypoint.sh @@ -20,11 +20,10 @@ echo -e "\033[36mExecuting helm\033[0m" helm_output=$(./run.sh) echo "$helm_output" -helm_output="${helm_output//'%'/'%25'}" -helm_output="${helm_output//$'\n'/'%0A'}" -helm_output="${helm_output//$'\r'/'%0D'}" - -echo "helm_output=$helm_output" >> $GITHUB_OUTPUT +delimiter="$(openssl rand -hex 8)" +echo "helm_output<<${delimiter}" >> "${GITHUB_OUTPUT}" +echo "$helm_output" >> "${GITHUB_OUTPUT}" +echo "${delimiter}" >> "${GITHUB_OUTPUT}" echo -e "\033[36mCleaning up: \033[0m" rm ./run.sh -Rf