Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template update 06/08/2020 #23

Closed
wants to merge 2 commits into from
Closed

Template update 06/08/2020 #23

wants to merge 2 commits into from

Conversation

fpervaiz
Copy link
Contributor

@fpervaiz fpervaiz commented Jun 8, 2020

Added LGSMigrants and MP solidarity templates
Fixed error where user address was included in MP details

This was linked to issues Jun 8, 2020
Template Request - LGSM Template #17
Open
Template Request - MP Solidarity #16
Open
davidswarbrick
davidswarbrick reviewed Jun 8, 2020
View reviewed changes
Copy link
Collaborator

@davidswarbrick davidswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely implemented templates!
My only comment is that on re-reading the templates we may be repeating content from others already implemented (which is my fault for submitting them). Will bring this to the attention of everyone before it's merged.

@davidswarbrick davidswarbrick removed the request for review from behradkoohy June 8, 2020 22:34
@davidswarbrick
Copy link
Collaborator

After discussion in meeting today - might want to remove mention of political party in LGSM template

@fpervaiz fpervaiz closed this Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidswarbrick davidswarbrick davidswarbrick left review comments

@behradkoohy behradkoohy Awaiting requested review from behradkoohy

@edwinbalani edwinbalani Awaiting requested review from edwinbalani

@puria-radmard puria-radmard Awaiting requested review from puria-radmard

@rafeeJ rafeeJ Awaiting requested review from rafeeJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template Request - LGSM Template Template Request - MP Solidarity
2 participants
@fpervaiz @davidswarbrick