-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a shortcode for nocookie youtube embeds #651
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
<?php | ||
/** | ||
* Add a shortcode for nocookie youtube embeds. | ||
* | ||
* These are not supported in the core embed block or shortcode. | ||
* See https://core.trac.wordpress.org/ticket/44610 | ||
*/ | ||
|
||
namespace WordPressdotorg\MU_Plugins\Plugin_Tweaks\Youtube_Shortcode; | ||
|
||
add_shortcode( 'youtube-nocookie', __NAMESPACE__ . '\render' ); | ||
|
||
/** | ||
* Render the youtube iframe. | ||
* | ||
* The shortcode content is the URL, checked against a safelist of | ||
* `youtube-nocookie` domains. Attributes can be `width`, `height`, | ||
* and `title. | ||
* | ||
* @param array $attr Shortcode attributes array, can be empty if the original arguments string cannot be parsed. | ||
* @param string $content Content inside shortcode tags. | ||
* | ||
* @return string HTML code for iframe embed. | ||
*/ | ||
function render( $attr, $content ) { | ||
// Short out early if the content is not a valid URL. | ||
// Returns null if content is not a URL at all. | ||
$host = wp_parse_url( $content, PHP_URL_HOST ); | ||
$valid_hosts = [ 'www.youtube-nocookie.com', 'youtube-nocookie.com' ]; | ||
if ( ! in_array( $host, $valid_hosts, true ) ) { | ||
return ''; | ||
} | ||
|
||
$defaults = array( | ||
'width' => '100%', | ||
'height' => false, | ||
'title' => 'YouTube video player', | ||
); | ||
$args = shortcode_atts( $defaults, $attr ); | ||
|
||
$html_attrs = ''; | ||
foreach ( $args as $name => $value ) { | ||
if ( $value ) { | ||
$html_attrs .= $name . '="' . esc_attr( $value ) . '" '; | ||
} | ||
} | ||
|
||
return sprintf( | ||
// `allow` settings copied from youtube-provided embed code. | ||
'<iframe style="aspect-ratio: 16/9;" src="%s" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerpolicy="strict-origin-when-cross-origin" allowfullscreen %s></iframe>', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would enforcing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
esc_url( $content ), | ||
$html_attrs | ||
); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor. Should this use numbered placeholders?