Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noindex unapproved comment previews. #8070

Conversation

peterwilsoncc
Copy link
Contributor

Adds a noindex directive to pages showing a preview of an unapproved comment prior to moderation.

Although the pages have a canonical URL referring to page without the comment preview has, the URL can be indexed by search engines none-the-less. I presume this is due to the content differing.

Trac ticket: Core-62760


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Jan 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props peterwilsoncc, flixos90, joostdevalk.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Jan 1, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@jdevalk
Copy link

jdevalk commented Jan 2, 2025

LGTM, thanks @peterwilsoncc !

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterwilsoncc, LGTM!

@peterwilsoncc peterwilsoncc added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 2, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 2, 2025
@peterwilsoncc
Copy link
Contributor Author

@felixarntz @jdevalk I realized overnight that the filter I used doesn't include the noarchive directive, should I use wp_robots_sensitive_page() instead?

@felixarntz
Copy link
Member

@felixarntz @jdevalk I realized overnight that the filter I used doesn't include the noarchive directive, should I use wp_robots_sensitive_page() instead?

I'm not sure. The change here is not really about a "sensitive page" I would argue, and when looking at other usages of wp_robots_no_robots() and wp_robots_sensitive_page(), the first seems to be more in line with what's needed here. But to be fair, I'm also unsure whether or not the noarchive needs to be set here.

@jdevalk
Copy link

jdevalk commented Jan 3, 2025

I’m ok with either

@peterwilsoncc
Copy link
Contributor Author

Thanks both, I'll go with the existing code to avoid complexity.

@peterwilsoncc peterwilsoncc force-pushed the fix/62760-noindex-unapproved-comments branch from 6bc8b21 to 0cd4b78 Compare January 5, 2025 21:14
@peterwilsoncc
Copy link
Contributor Author

Merged r59576 / 938d27a

@peterwilsoncc peterwilsoncc deleted the fix/62760-noindex-unapproved-comments branch January 5, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants