-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add folder and files for Twenty Twenty-Five #7459
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
5ddf4c4
to
a3bd227
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me for an initial merge.
I've noticed the following, none of which I think are blockers:
- a number of sample text strings in various files will need to be made translatable
- I've pushed a minor fix for some commenting standards that will need to merged upstream, see 6c07c1e
I've updated the default theme constant and verified it works.
The PHP Unit test failures are unrelated.
A props list will need to be generated from https://github.com/WordPress/twentytwentyfive/ for the core commit.
a3bd227
to
9c0a27d
Compare
Trac ticket:
https://core.trac.wordpress.org/ticket/62103
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.