You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.
For some blocks blocks/***/theme.min.css is used to keep consistency across the UI(editor/frontend) and add_theme_support( 'wp-block-styles' ); is used to add theme.min.css's CSS as inline-CSS at fronted. As Twenty Twenty Three theme no longer uses functions.php.
Before I open any PR, I want to discuss solutions to keep consistency across the UI.
Adding back functions.php for this only not seems a good idea.
Adding custom CSS is not a good idea.
Moving blocks/***/theme.min.css CSS to blocks/***/style.scss. Might be. But backward compatibility.
Improve those blocks style that uses 'theme.min.css`. Yes, this soulation LGTM.
Here are blocks that have style consistency issues.
The text was updated successfully, but these errors were encountered:
I would expect those styles to not be loaded in the editor unless the theme supports wp-block-styles. I think this is a Gutenberg bug or even possibly a regression.
Looking at the code, I can see that if $editor_styles is empty, we load wp-block-library-theme as a dependency for wp-edit-blocks style. Perhaps we should remove the dependency from there? (in client-assets.php)
For some blocks
blocks/***/theme.min.css
is used to keep consistency across the UI(editor/frontend) andadd_theme_support( 'wp-block-styles' );
is used to addtheme.min.css
's CSS as inline-CSS at fronted. As Twenty Twenty Three theme no longer usesfunctions.php
.Before I open any PR, I want to discuss solutions to keep consistency across the UI.
functions.php
for this only not seems a good idea.blocks/***/theme.min.css
CSS toblocks/***/style.scss
. Might be. But backward compatibility.Here are blocks that have style consistency issues.
The text was updated successfully, but these errors were encountered: