Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring the details included in the comment #38

Closed
gziolo opened this issue Feb 1, 2024 · 4 comments · Fixed by #61 or #64
Closed

Allow configuring the details included in the comment #38

gziolo opened this issue Feb 1, 2024 · 4 comments · Fixed by #61 or #64
Assignees
Labels
[Type] Feature Request New feature or request

Comments

@gziolo
Copy link
Member

gziolo commented Feb 1, 2024

Problem

See #21 (comment).

This is how part of the comment looks like today:

Screenshot 2024-02-01 at 13 13 28

Feature Request

Would it be possible to make this configurable? While Core SVN makes perfect sense in WordPress develop, the GitHub Merge isn't that useful. Then, when contributing to Gutenberg, it was exactly the other way around. So, while the default could be as is, what if you could pass the setting when defining the GitHub workflow?

svnProps: true
gitCoAuthored: true

Workaround

No response

Repository

No response

@gziolo gziolo added the [Type] Feature Request New feature or request label Feb 1, 2024
@desrosj
Copy link
Contributor

desrosj commented Feb 1, 2024

Thanks @gziolo!

I think this is reasonable. But, there's one scenario that comes to mind, though.

In WordPress/wordpress-develop, it's not uncommon for change suggestions in a PR to be copied over into a Gutenberg one. In that scenario, would it be helpful for the maintainer to have the GitHub-flavored list in order to include it in the Gutenberg merge?

Maybe we could add the ability to tell props bot to include both formats somehow. Maybe a props-bot-both label or something?

@gziolo
Copy link
Member Author

gziolo commented Feb 1, 2024

In WordPress/wordpress-develop, it's not uncommon for change suggestions in a PR to be copied over into a Gutenberg one.

I didn't consider that scenario. Interesting. Maybe it's best to keep both for now and see whether it creates too much noise.

@noisysocks
Copy link
Member

noisysocks commented Feb 2, 2024

Didn't see this issue before opening #47.

I think it's currently far too noisy having both lists. At the very least we could collapse the non-relevant one behind a <detail>.

@noisysocks
Copy link
Member

In WordPress/wordpress-develop, it's not uncommon for change suggestions in a PR to be copied over into a Gutenberg one. In that scenario, would it be helpful for the maintainer to have the GitHub-flavored list in order to include it in the Gutenberg merge?

I think you're over-optimising for an edge case here 😀 It's much much much more common (~20 new PRs are opened in Gutenberg every day) that you don't want this extra information than that you do want it.

aaronjorbin added a commit that referenced this issue Feb 8, 2024
Take 2.  

Fixes #38, #47.
See: #61, #63.

Co-authored-by: desrosj <[email protected]>
Co-authored-by: aaronjorbin <[email protected]>
Co-authored-by: noisysocks <[email protected]>
Co-authored-by: gziolo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Feature Request New feature or request
Projects
None yet
3 participants