From 07121fb433b20d48272e1bfd413cabc06b7ba03c Mon Sep 17 00:00:00 2001 From: benazeer1909 <91200605+benazeerhassan1909@users.noreply.github.com> Date: Thu, 24 Oct 2024 00:21:41 +0530 Subject: [PATCH 1/8] Border support added for Page-list block --- packages/block-library/src/page-list/block.json | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/packages/block-library/src/page-list/block.json b/packages/block-library/src/page-list/block.json index b465e4ef5dc3d..ec48d47240604 100644 --- a/packages/block-library/src/page-list/block.json +++ b/packages/block-library/src/page-list/block.json @@ -51,6 +51,18 @@ }, "interactivity": { "clientNavigation": true + }, + "__experimentalBorder": { + "radius": true, + "color": true, + "width": true, + "style": true, + "__experimentalDefaultControls": { + "radius": true, + "color": true, + "width": true, + "style": true + } } }, "editorStyle": "wp-block-page-list-editor", From e74fc5772c0cf9e102ca87d36040937eccc07896 Mon Sep 17 00:00:00 2001 From: benazeer1909 <91200605+benazeerhassan1909@users.noreply.github.com> Date: Thu, 24 Oct 2024 00:21:41 +0530 Subject: [PATCH 2/8] Border support added for Page-list block --- packages/block-library/src/page-list/block.json | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/packages/block-library/src/page-list/block.json b/packages/block-library/src/page-list/block.json index b465e4ef5dc3d..ec48d47240604 100644 --- a/packages/block-library/src/page-list/block.json +++ b/packages/block-library/src/page-list/block.json @@ -51,6 +51,18 @@ }, "interactivity": { "clientNavigation": true + }, + "__experimentalBorder": { + "radius": true, + "color": true, + "width": true, + "style": true, + "__experimentalDefaultControls": { + "radius": true, + "color": true, + "width": true, + "style": true + } } }, "editorStyle": "wp-block-page-list-editor", From 3406a5ad551f538a8b8cb3220c9cb157451bcdaf Mon Sep 17 00:00:00 2001 From: benazeer Date: Thu, 24 Oct 2024 16:22:18 +0530 Subject: [PATCH 3/8] Adding spacing support for page list --- packages/block-library/src/page-list/block.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/block-library/src/page-list/block.json b/packages/block-library/src/page-list/block.json index ec48d47240604..4e13e34af5bd4 100644 --- a/packages/block-library/src/page-list/block.json +++ b/packages/block-library/src/page-list/block.json @@ -63,6 +63,10 @@ "width": true, "style": true } + }, + "spacing": { + "padding": true, + "margin": true } }, "editorStyle": "wp-block-page-list-editor", From 5e30be010107022ff01ba5055314b92830a5bad6 Mon Sep 17 00:00:00 2001 From: benazeer Date: Thu, 24 Oct 2024 22:26:06 +0530 Subject: [PATCH 4/8] Doc Build --- docs/reference-guides/core-blocks.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/reference-guides/core-blocks.md b/docs/reference-guides/core-blocks.md index dd49d15685724..e3bb3ee5d5c54 100644 --- a/docs/reference-guides/core-blocks.md +++ b/docs/reference-guides/core-blocks.md @@ -512,7 +512,7 @@ Display a list of all pages. ([Source](https://github.com/WordPress/gutenberg/tr - **Name:** core/page-list - **Category:** widgets - **Allowed Blocks:** core/page-list-item -- **Supports:** interactivity (clientNavigation), typography (fontSize, lineHeight), ~~html~~, ~~reusable~~ +- **Supports:** interactivity (clientNavigation), spacing (margin, padding), typography (fontSize, lineHeight), ~~html~~, ~~reusable~~ - **Attributes:** isNested, parentPageID ## Page List Item From 2b74676c57ec97cf0a8af2209ed7d0ccbd483090 Mon Sep 17 00:00:00 2001 From: Benazeer Hassan <66269472+benazeer-ben@users.noreply.github.com> Date: Mon, 11 Nov 2024 12:24:40 +0530 Subject: [PATCH 5/8] Update packages/block-library/src/page-list/block.json Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> --- packages/block-library/src/page-list/block.json | 6 ------ 1 file changed, 6 deletions(-) diff --git a/packages/block-library/src/page-list/block.json b/packages/block-library/src/page-list/block.json index 4e13e34af5bd4..81a2e014146b2 100644 --- a/packages/block-library/src/page-list/block.json +++ b/packages/block-library/src/page-list/block.json @@ -57,12 +57,6 @@ "color": true, "width": true, "style": true, - "__experimentalDefaultControls": { - "radius": true, - "color": true, - "width": true, - "style": true - } }, "spacing": { "padding": true, From 766c6550ffd93adb51614b97fe279fec7a9c9e5f Mon Sep 17 00:00:00 2001 From: Benazeer Hassan <66269472+benazeer-ben@users.noreply.github.com> Date: Mon, 11 Nov 2024 12:25:16 +0530 Subject: [PATCH 6/8] Update packages/block-library/src/page-list/block.json Suggestion commit Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> --- packages/block-library/src/page-list/block.json | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/block-library/src/page-list/block.json b/packages/block-library/src/page-list/block.json index 81a2e014146b2..db48c8f824f3e 100644 --- a/packages/block-library/src/page-list/block.json +++ b/packages/block-library/src/page-list/block.json @@ -60,7 +60,11 @@ }, "spacing": { "padding": true, - "margin": true + "margin": true, + "__experimentalDefaultControls": { + "padding": false, + "margin": false + } } }, "editorStyle": "wp-block-page-list-editor", From cceb53e8f5cb3a5ac8b9074aca9a00d824044ab2 Mon Sep 17 00:00:00 2001 From: benazeer-ben Date: Mon, 11 Nov 2024 12:28:28 +0530 Subject: [PATCH 7/8] Unwanted Comma removed --- packages/block-library/src/page-list/block.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-library/src/page-list/block.json b/packages/block-library/src/page-list/block.json index db48c8f824f3e..16a620dc177d7 100644 --- a/packages/block-library/src/page-list/block.json +++ b/packages/block-library/src/page-list/block.json @@ -56,7 +56,7 @@ "radius": true, "color": true, "width": true, - "style": true, + "style": true }, "spacing": { "padding": true, From 44ff296f679210e85789610feb177d49865df3fa Mon Sep 17 00:00:00 2001 From: benazeer-ben Date: Tue, 12 Nov 2024 10:59:24 +0530 Subject: [PATCH 8/8] border-box added --- packages/block-library/src/page-list/style.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/block-library/src/page-list/style.scss b/packages/block-library/src/page-list/style.scss index d06a6142573be..ab04d57e61b96 100644 --- a/packages/block-library/src/page-list/style.scss +++ b/packages/block-library/src/page-list/style.scss @@ -15,3 +15,7 @@ background-color: inherit; } } +.wp-block-page-list { + // This block has customizable padding, border-box makes that more predictable. + box-sizing: border-box; +}