List layout: update broken styles #64837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
force-pushed
the
fix/media-placeholder-size
branch
from
927b167 to
d2a3477
Compare
oandregal
added
[Type] Bug
|
@jameskoster I was looking at the media field in the list view and wanted to gather your thoughts on hiding the media field if it is not provided? I see two use cases:
Do you think we could offer hiding the media field in the 2nd scenario? To be honest, I have doubts myself given that it acts as a sort of "visual anchor", but want to double-check. |
|
Size Change: +46 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
oandregal
commented
Aug 27, 2024
| @@ -1,3 +1,7 @@ | |||
| ul.dataviews-view-list { | |||
| list-style-type: none; | |||
There was a problem hiding this comment.
I presume we don't see the list-style-type our dataviews implementation (pages, patterns, templates) because there's a reset somewhere (the block library one?). Thought we should have this for consumers without having to depend on a different reset.
There was a problem hiding this comment.
Why not add it below in the existing selector?
There was a problem hiding this comment.
Not very opinionated. My thinking was that ul.dataviews-view-list targets the UL element so it's more intentional.
ntsekouras
approved these changes
Aug 28, 2024
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
Co-authored-by: oandregal <[email protected]> Co-authored-by: ntsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Update list layout styles:
Why?
So they don't look broken and consumers of this package have a better devexp.
How?
Testing Instructions
npm install && npm run storybook:dev.