DataViews: Fix field rendering #63452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
commented
Jul 11, 2024
| @@ -73,7 +73,7 @@ export type Field< Item > = { | |||
| /** | |||
| * Callback used to render the field. Defaults to `field.getValue`. | |||
| */ | |||
| render?: ( args: { item: Item } ) => ReactNode; | |||
| render?: ComponentType< { item: Item } >; | |||
There was a problem hiding this comment.
updating the type actually forces us to use the property properly and prevents us from doing the same error in the future.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +77 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
What?
So it turns out that we were making a noob error when rendering the different fields of the dataviews, while the fields have
renderproperty that is supposed to be a component, we were not rendering it as a component, instead we were just calling it as a regular function. The problem with that is that if a render property was usinguseSelector any other hook, it would result in errors as we enable/disable the fields.The other issue is that it might have had a bad impact on performance potentially as all React and useSelect optimizations were probably ignored.
Testing Instructions
1- Open the "pages" data views
2- Toggle the "author" field on and off
3- it results in an error in trunk but this PR solves the issue.