DataViews: In list view, automatically insert header menu separators #55412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In HeaderMenu, avoid the very error-prone logic involved in manually adding separators in between top-level items, and instead rely on an introspective component (WithSeparators) to do that task reliably.
mcsf
added
the
[Feature] DataViews
mcsf
commented
Oct 17, 2023
| </DropdownMenuV2> | ||
| ); | ||
| } | ||
|
|
||
| function WithSeparators( { children } ) { |
There was a problem hiding this comment.
The exact details of where this should live aren't really important to me, whether it's here in the module or somewhere to be reused, or incorporated in DropdownMenu.
|
Size Change: +44 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Oct 17, 2023
ntsekouras
added
the
[Type] Code Quality
|
For the record, I also explored an alternative that didn't rely on the Children API, since its use is discouraged. The alternative is more verbose and cumbersome, as it trades element trees for plain object trees. I'm attaching it here for future reference: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be reviewed with whitespace changes hidden.
In HeaderMenu, avoid the very error-prone logic involved in manually adding separators in between top-level items, and instead rely on an introspective component (WithSeparators) to do that task reliably. The complexity that this eliminates is expected to grow as more features result in more top-level items in header menus.
No visible or functional change is expected from this PR, but for reference these are the menus in question:
Before, a separator needed to be manually inserted in between the sorting group (top) and the visibility item (bottom).
Minor part of #55083