DataViews: Add featured image field to the page list #55246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Experimental
|
Size Change: +338 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Oct 11, 2023
|
Flaky tests detected in f8f8a93d76623cbe36607a6465a3da6fe0cf7d1a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6480475946
|
ntsekouras
force-pushed
the
add/data-views-featured-image
branch
from
f8f8a93 to
69e0750
Compare
mcsf
reviewed
Oct 12, 2023
| const sizesPerPriority = [ 'large', 'thumbnail' ]; | ||
| const currentSize = | ||
| size ?? | ||
| sizesPerPriority.find( ( s ) => !! media?.media_details?.sizes[ s ] ); |
There was a problem hiding this comment.
I'm picking nits, but xs.find( x => !! f( x ) ) is better expressed as xs.some( x => f( x ) ) Edit: I misread, it's just that the !! is unnecessary.
There was a problem hiding this comment.
@mcsf I'm kind of lazy to open a PR just for these 😬
There was a problem hiding this comment.
Yeah, I know, no need to open one! Just an FYI, and then whoever of us is touching these files may or may not decide to change it. :)
There was a problem hiding this comment.
@mcsf some will return a boolean value and not the size though.
There was a problem hiding this comment.
Oh yeah, I misread the intention here. So it's just that !! is unnecessary, but find is still the right idiom. Carry on. <homer-disappear.gif>
| header: __( 'Featured Image' ), | ||
| accessorFn: ( page ) => page.featured_media, | ||
| cell: ( props ) => | ||
| !! props.row.original.featured_media ? ( |
There was a problem hiding this comment.
Still picking nits with !!: this cast-to-boolean inside the ternary condition is unnecessary. :)
There was a problem hiding this comment.
I like these when the props are not booleans 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
What?
The grid data view layout requires items to have a media to render per item. So before starting to explore the grid layout, I wanted to add a "media" field to the table view. This small PR just adds the featured image field to the pages list data view in the site editor.
I wanted to ensure that this field is actually hidden initially, in the initial view config but it's not possible yet to control the visibility from the view config. I believe @ntsekouras is working on that in parallel.
Testing Instructions
1- Add some pages with featured images
2- Make sure the featured image column in visible properly in the table view