Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Template part is missing an icon in the sidebar #68649

Closed
Mamaduka opened this issue Jan 14, 2025 · 1 comment · Fixed by #68653
Closed

Site Editor: Template part is missing an icon in the sidebar #68649

Mamaduka opened this issue Jan 14, 2025 · 1 comment · Fixed by #68653
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Regression Related to a regression in the latest release

Comments

@Mamaduka
Copy link
Member

The document settings sidebar no longer displays an icon for the Template Part. This is probably a regression after #66459.

Code in question:

return (
(
select( coreStore ).getEntityRecord(
'root',
'__unstableBase'
)?.default_template_part_areas || []
).find( ( item ) => options.area === item.area )?.icon ||
layout

The icon returned from default_template_part_areas is just a string value and isn't recognized by the Icon component.

cc @gigitux

Testing Instructions

  1. Open the Site Editor.
  2. Edit a Header template part.
  3. Confirm that no icon is displayed in document settings.

Screenshot

Image

@Mamaduka Mamaduka added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Regression Related to a regression in the latest release labels Jan 14, 2025
@im3dabasia
Copy link
Contributor

Thank you for reporting this issue @Mamaduka .

I was able to reproduce this issue and can confirm that the logo is not displayed.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants