Fix usage of tooltip in the Circular option picker. #68602
+72
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: -43 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
afercia
requested review from
ajitbohra,
ellatrix and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Note: The changes in this PR are pretty simple but required to adjust a pretty decent amount of tests to remove the prefix |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68601
What?
Why?
Tooltips must be used to visually expose the accessible name, there shouldn't be a mismatch between the visible text and the accessible name. Also, redundant announcement are just noisy.
How?
Turns out both
OptionAsOptionandOptionAsButtonuse the Button component under the hood. This PR leverages the Buttonlabelprop to render a tooltip instead of wrapping the component within a Tooltip.ColorPalettecomponent.labelprop by using the existingtooltipTextprop as its value.Testing Instructions
aria-describedbyattribute added to the currently focused color button.Testing Instructions for Keyboard
Screenshots or screencast