Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Show template" option persistent #68250

Open
annezazu opened this issue Dec 23, 2024 · 4 comments · May be fixed by #68257
Open

Make "Show template" option persistent #68250

annezazu opened this issue Dec 23, 2024 · 4 comments · May be fixed by #68257
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

Right now, due to this change, the template is shown by default when editing pages. Alongside this, is a "show template" option that can be toggled on/off. Currently, if you enter a page, turn off the template, and then leave and return the show template option doesn't persist. I think making it persistent will happen lessen future feedback I'm expected from this change as folks could opt out once and move on.

@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement. labels Dec 23, 2024
@yogeshbhutkar
Copy link
Contributor

I’d like to delve deeper into this enhancement. Setting this value in the preferences store seems like a solid approach. I’ll be submitting a PR to implement this soon.

@Mamaduka
Copy link
Member

I don't think another persistent option is a solution here, and a feature introduced via #62304 can be opted out. Smart defaults should be preferred over the software options.

Let's avoid patching any editor behavior that is not final. Please look at the ongoing discussion in #62304 and #67867.

@jasmussen
Copy link
Contributor

Thanks for the issue, thanks for the PR. I'd echo Mamaduka, it's not clear that making this persistent is a win, there are pros and cons. It's a good discussion tracking issue to start.

@Mamaduka
Copy link
Member

It's a good discussion-tracking issue to start.

Definitely! I'll circle back here when this feature's implementation details are clear/final.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
4 participants