Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor "Settings" panel of Site Title block to use ToolsPanel instead of PanelBody #67901

Closed
fabiankaegy opened this issue Dec 12, 2024 · 1 comment · Fixed by #67898 or #68295
Closed

Refactor "Settings" panel of Site Title block to use ToolsPanel instead of PanelBody #67901

fabiankaegy opened this issue Dec 12, 2024 · 1 comment · Fixed by #67898 or #68295
Labels
[Block] Site Title Affects the Site Title Block [Type] Enhancement A suggestion for improvement.

Comments

@fabiankaegy
Copy link
Member

fabiankaegy commented Dec 12, 2024 •
edited
Loading

Part of #67813

Convert the "Settings" panel of the Site Title block to use the ToolsPanel instead of PanelBody
@fabiankaegy fabiankaegy mentioned this issue Dec 12, 2024
Open
@fabiankaegy fabiankaegy linked a pull request Dec 12, 2024 that will close this issue
Site Title Block: Refactor settings panel to use ToolsPanel #67898
Merged
@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Site Title Affects the Site Title Block labels Dec 13, 2024
@t-hamano
Copy link
Contributor

t-hamano commented Dec 23, 2024 •
edited
Loading

I am reopening this issue as there are issues that need to be resolved.

See #67898 (comment)

cc @Sukhendu2002

@t-hamano t-hamano reopened this Dec 23, 2024
@Sukhendu2002 Sukhendu2002 mentioned this issue Dec 25, 2024
Merged
@t-hamano t-hamano linked a pull request Dec 26, 2024 that will close this issue
Update SiteTitle block to Fix isLink Toggle Behavior #68295
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Site Title Affects the Site Title Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
2 participants
@fabiankaegy @t-hamano