Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Cleanup potentially unnecessary action spies #67834

Open
tyxla opened this issue Dec 11, 2024 · 0 comments
Open

Storybook: Cleanup potentially unnecessary action spies #67834

tyxla opened this issue Dec 11, 2024 · 0 comments
Assignees
Labels
Storybook Storybook and its stories for components [Type] Enhancement A suggestion for improvement.

Comments

@tyxla
Copy link
Member

tyxla commented Dec 11, 2024

In order to get the Storybook v8 upgrade to pass in #67574, I added some action spies, because without them, I was getting these errors for a few stories:

Image

See these for more details:

We believe that this isn't an optimal solution, as this feels like a false positive.

So, we should remove those action spies, but to do that we need to learn what really tricks Storybook into causing those errors, and how we can work around it better.

cc @ciampo

@tyxla tyxla added [Type] Enhancement A suggestion for improvement. Storybook Storybook and its stories for components labels Dec 11, 2024
@tyxla tyxla self-assigned this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant