Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce DropdownMenu to follow the ARIA menu pattern or add linting to make sure it does #67795

Open
2 of 6 tasks
afercia opened this issue Dec 10, 2024 · 0 comments
Open
2 of 6 tasks
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Dec 10, 2024

Description

Splitting this out from #67647 (comment)

There have been several cases where extraneous content such as paragraphs with descriptions or other extraneous content have been used inside the ARIA menu rendered by DropdownMenu.

ARIA menus can only contain menuitems (including the menuitemradio and menuitemcheckbox variants), groups and separators. No other content type is allowed within an ARIA menu.

It would be good ot prevent such misusage and breakage of the ARIA pattern by enforcing this constrain via code or, at the very least, by adding some linting rule to prevent extraneous content from being used inside a DropdownMenu.

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Bug An existing feature does not function as intended labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant