Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor Welcome Guide: fix spacing to remove widow #67601

Open
annezazu opened this issue Dec 4, 2024 · 1 comment
Open

Block Editor Welcome Guide: fix spacing to remove widow #67601

annezazu opened this issue Dec 4, 2024 · 1 comment
Labels
Needs Copy Review Needs review of user-facing copy (language, phrasing) Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended [Type] Copy Issues or PRs that need copy editing assistance

Comments

@annezazu
Copy link
Contributor

annezazu commented Dec 4, 2024 •
edited
Loading

In reviewing this PR, I noticed that we have widows for each frame of the welcome guide. I don't remember this being the case previously so something must have changed!

Image
Image
Image

Min width of 368px ends up fixing it for the first two (not the library one) but also makes it look a bit too wide:

Image

Rather than making it larger, we could also try shortening each title. The following options appropriately fit into one line:

  • Welcome to the block editor > Welcome to the editor
  • Make each block your own > Customize each block
  • Get to know the block library > Explore all blocks
  • Learn how to use the block editor > Learn more
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Type] Copy Issues or PRs that need copy editing assistance Needs Copy Review Needs review of user-facing copy (language, phrasing) Needs Design Feedback Needs general design feedback. labels Dec 4, 2024
@annezazu annezazu mentioned this issue Dec 4, 2024
Closed
@kristastevens
Copy link

Hi @annezazu! Your options are great! They're clear and succinct.

@benazeer-ben benazeer-ben mentioned this issue Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Copy Review Needs review of user-facing copy (language, phrasing) Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kristastevens @annezazu