Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metaboxes are not shown when editor rendering mode is set to template-locked #66507

Closed
fabiankaegy opened this issue Oct 27, 2024 · 0 comments · Fixed by #66508
Closed

Metaboxes are not shown when editor rendering mode is set to template-locked #66507

fabiankaegy opened this issue Oct 27, 2024 · 0 comments · Fixed by #66508
Assignees
Labels
[Feature] Meta Boxes A draggable box shown on the post editing screen [Type] Bug An existing feature does not function as intended

Comments

@fabiankaegy
Copy link
Member

The editor usually shows the traditional metaboxes at the bottom of the screen. Big players such as Yoast or Multilingualpress are still using this metabox location so we even made the effort to now support having it visible when the post editor is rendered in an iframe.

However in testing I just noticed that we are only showing the metaboxes when the rendering mode of the editor is set to post-only. To me this doesn't really make sense. The template-locked rendering mode to me also deserves to get the metabox area displayed. Because at that point in time you are still editing a post and therefore metadata of said post.

Only when you get to the template-only mode does it make sense to hide that metabox area as we are no longer in the context of a single post.

showMetaBoxes:
! DESIGN_POST_TYPES.includes( currentPostType ) &&
isRenderingPostOnly,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Meta Boxes A draggable box shown on the post editing screen [Type] Bug An existing feature does not function as intended
Projects
None yet
1 participant