Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render tools control when getRenderingMode is set to post-only #65678

Closed
richtabor opened this issue Sep 26, 2024 · 3 comments
Closed

Don't render tools control when getRenderingMode is set to post-only #65678

richtabor opened this issue Sep 26, 2024 · 3 comments
Labels
[Feature] Edit Mode Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

The write and design tools selection UI is relevant when editing content like blog posts. The tools are most helpful in the context of templates. I propose the control is not rendered if getRenderingMode() is set to post-only.

In trunk, this condition can be set via the Inspector's Template control, by choosing to change the template display with the "Show template" option (in both the post editor and site editor).

Tools UI

CleanShot 2024-09-25 at 17 58 26

Showing and hiding a template with getRenderingMode

CleanShot 2024-09-26 at 09 28 52

Ideally the UX for showing and hiding a template should be clearer (not buried in the Inspector). I'll open another issue to push that forward.

@draganescu
Copy link
Contributor

draganescu commented Oct 22, 2024

Should we instead of hiding the control, switch out of post only if design is selected? Isn't that more fluid than disappearing UI elements?

It does conflict a bit with the saved pref thing - going the route I suggest above would mean that once you set design mode then all posts will be in template mode until you switch back to write mode. But I still think this is an easier thing to handle than hiding the control based on a settong in a list of settings in a tab in the inspector.

@draganescu draganescu added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Oct 22, 2024
@richtabor
Copy link
Member Author

Closing in favor of #66775 (its more detailed/more current).

@richtabor
Copy link
Member Author

It does conflict a bit with the saved pref thing

Yea, that's my hesitation there. I'm also aware of users accidentally triggering "Write" mode when the template is not previewed, resulting in a challenging experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Edit Mode Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants