Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search block: setting option to button only causes UI inconsistency in displaying search field #64988

Open
annezazu opened this issue Sep 2, 2024 · 1 comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Search Affects the Search Block - used to display a search field Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Sep 2, 2024

When adding the search block to the navigation block and setting it to display button only, I noticed some wonkiness in whether the search field is shown. The current experience make it seem like you have to select Button only twice for it to "work" (you don't! it works the first time but it's trying to show the search field to show you can customize the placeholder) and then, when selecting it, it won't show the search field until you click twice. The entire experience doesn't feel very refined and consistent. The following videos were taking using WordPress 6.6.1 with Gutenberg 19.1.

This first came up from @Marc-pi in a prior issue:

there is just an inconcistencies in the Editor when clicking on the "button only" option, we have to insist and click twice to make it effective, but we can live with it
we can close

Inconsistencies when search field is shown

Ensure consistency so that, upon selecting the block, each time the search field is shown so you can edit the placeholder text.

button.only.wonkines.mov

Better show that you don't need to select "button only" twice

Better communicate that even the "button only" shows a placeholder field so you can customize it on the front end, even as that doesn't show until you click the button. Right now, it seems as if you have to select the option twice for it to stick as shown below:

Screen.Recording.2024-09-02.at.11.48.41.AM.mov
@annezazu annezazu added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Block] Navigation Affects the Navigation Block [Block] Search Affects the Search Block - used to display a search field labels Sep 2, 2024
@jasmussen
Copy link
Contributor

The main feedback I'd share on this is that the way to configure the search block hasn't scaled well, and can likely benefit from some of the options existing in the inspector panel. It's especially the button position dropdown that's tricky, and could benefit from a rethink.

It's not clear that a redesign is the immediate solution here, however, this looks like a bug that should ideally be investigated and fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Search Affects the Search Block - used to display a search field Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants