Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Make 'Manage menus' button link to site-editor.php?postType=wp_navigation #62257

Open
Tracked by #62680
noisysocks opened this issue Jun 4, 2024 · 6 comments
Labels
[Block] Navigation Affects the Navigation Block [Feature] Navigation Menus Any issue relating to Navigation Menus [Type] Enhancement A suggestion for improvement.

Comments

@noisysocks
Copy link
Member

noisysocks commented Jun 4, 2024

I was testing creating a block-based website from scratch and got confused when I came across this very sad looking 'Mange menus' link that appears in the Advanced panel when a Navigation block is selected:

Screenshot 2024-06-03 at 15 25 31
  1. It looks unpolished. Should it be a variant="secondary" button and not a link?

  2. I'd expect it to be located with the other menu management controls:

    Screenshot 2024-06-04 at 12 05 07
  3. I'd expect it to link to site-editor.php?postType=wp_navigation and not edit.php?post_type=wp_navigation which is very clunky and requires the user to save/discard their changes.

@noisysocks noisysocks added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Block] Navigation Affects the Navigation Block [Feature] Navigation Menus Any issue relating to Navigation Menus labels Jun 4, 2024
@jasmussen
Copy link
Contributor

Good issue. I would link it to the site editor navigation section (/wp-admin/site-editor.php?postType=wp_navigation), however, which I would expect to get the new data views in the not too distant future.

@noisysocks noisysocks removed the Needs Design Feedback Needs general design feedback. label Jun 11, 2024
@noisysocks
Copy link
Member Author

@jasmussen: Do you think we should move it to the ellipsis menu or keep it in Advanced?

@jasmussen
Copy link
Contributor

It's been in the ellipsis menu before, in fact it's moved around a bit. I recall personally advocating for the ellipsis menu, since there's a dedicated Navigation section in the site editor. But I'm also generally deferring to feedback here, so it may be best to keep it where it is.

There's an open question of the classic themes behavior here.

@youknowriad
Copy link
Contributor

youknowriad commented Dec 4, 2024

Hey folks! I came to this issue after a discussion with @fabiankaegy

I think the edit.php?post_type=wp_navigation page is very confusing, the only place to access it is using the "Manage menus" link and when you click an item there you navigate to the site editor. It makes for a very confusing flow.

I would suggest to repurpose this issue or create a new issue to do the following instead:

  • Remove access to this page
  • Make this menu navigate to the site editor's "navigation" page
  • Allow access to the site editor's navigation page for classic themes (just like we do for patterns).

@getdave @jasmussen @oandregal @MaggieCabrera

@jasmussen
Copy link
Contributor

Remove access to this page
Make this menu navigate to the site editor's "navigation" page
Allow access to the site editor's navigation page for classic themes (just like we do for patterns).

Makes sense to me 👍 👍

CC: @fcoveram as he's been pondering aspects related to this lately, and @tellthemachines as she's been looking at unifying a couple of elements inside the site editor for classic editor (styles, patterns). Further, CC: @jameskoster as you argued for bringing data views to the Site Editor > Navigation section, which could be all the more urgent based on this.

@getdave
Copy link
Contributor

getdave commented Dec 5, 2024

This seems like a reasonable approach.

Also worth noting that we're looking to add Dataviews support for Navigation

#65828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Navigation Menus Any issue relating to Navigation Menus [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants