-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation: Make 'Manage menus' button link to site-editor.php?postType=wp_navigation #62257
Comments
Good issue. I would link it to the site editor navigation section ( |
@jasmussen: Do you think we should move it to the ellipsis menu or keep it in Advanced? |
It's been in the ellipsis menu before, in fact it's moved around a bit. I recall personally advocating for the ellipsis menu, since there's a dedicated Navigation section in the site editor. But I'm also generally deferring to feedback here, so it may be best to keep it where it is. There's an open question of the classic themes behavior here. |
Hey folks! I came to this issue after a discussion with @fabiankaegy I think the I would suggest to repurpose this issue or create a new issue to do the following instead:
|
Makes sense to me 👍 👍 CC: @fcoveram as he's been pondering aspects related to this lately, and @tellthemachines as she's been looking at unifying a couple of elements inside the site editor for classic editor (styles, patterns). Further, CC: @jameskoster as you argued for bringing data views to the Site Editor > Navigation section, which could be all the more urgent based on this. |
This seems like a reasonable approach. Also worth noting that we're looking to add Dataviews support for Navigation |
I was testing creating a block-based website from scratch and got confused when I came across this very sad looking 'Mange menus' link that appears in the Advanced panel when a Navigation block is selected:
It looks unpolished. Should it be a
variant="secondary"
button and not a link?I'd expect it to be located with the other menu management controls:
I'd expect it to link to
site-editor.php?postType=wp_navigation
and notedit.php?post_type=wp_navigation
which is very clunky and requires the user to save/discard their changes.The text was updated successfully, but these errors were encountered: