Remove "Advanced" toggle from LinkControl #60442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that Yoast takes over the Link Control anyhow. This is what you see when Yoast is active (sans the "Advanced" toggle):
|
richtabor
added
[Feature] Link Editing
|
Size Change: -558 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
|
I don't know where the discussion behind this PR is, but I agree with removing the Advanced toggle. I'd love to hear other people's opinions. If we are to move forward with this PR, I think the following points need to be changed.
Yes, Yoast SEO plugin has its own inline functionality and implements |
|
Yes to removing. If we get to a point where more settings are needed we can reconsider but with just two items it's not as useful |
|
Another yes to removing. If there are future plans to add many more options, it can be revisited then. |
|
I would rather move it back to the top of the popover and keep the advanced toggle 🤷🏻 because these are advanced options for links and because the folks annoyed by the recent changes want it as it were. |
I don't this this works, bringing the whole toggle to the preview. But we could do something like this potentially, respecting the same user preference that the advanced toggle has, where it says open if you've toggled it open. CleanShot.2024-04-23.at.14.55.04.mp4Here's bringing the whole toggle: CleanShot.2024-04-23.at.15.00.10.mp4 |
|
i like the integrated toggle next to the actions in the preview, makes more sense to me. I just don't know if it's worth losing the copy link button. |
Agreed. |
|
Here it is with the copy icon as well:
|
|
In #61056, it was suggested to add custom CSS. If this were implemented, the layout would look like this: If there is a possibility that custom CSS will be added in the future, we may want to leave the Advanced toggle as is.
|
|
Closing as we don't have consensus on the direction yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Try removing the "Advanced" toggle and associated preference to simplify a bit.
Testing Instructions
Screenshots or screencast