-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Library: Include a "Select All" option when activating/deactivating fonts #59704
Comments
Good followup to #45271 which actually already includes a table heading and a similar toggle that selects all. Here it is in an updated version with the toggle on the left: |
CC: @mikachan @matiasbenedetto for aweareness. |
Noting that this is mentioned here too: #56688 |
Note that there's a sister issue for this related to installing fonts: #58011 |
For any performance issues related to selecting multiple variants, do we already have an issue for smartly loading only the font-weights used on a particular page, or do we still need to create such an issue? |
@jasmussen Good question! A So selecting all the variants of a font doesn't cause a performance problem by itself--it's one extra line of html added to the page for each variant. The performance issue comes if all the variants are available, and the styles settings on a page call for loading all of them (e.g. you've picked lots of similar but different weights in the styles settings for blocks that load on the page). |
I responded here, thanks for clarifying! |
What problem does this address?
It's quite time consuming and burdensome to have to select each font weight when I want to add or remove an entire font family. I suggest we add a "Select All" tick at the top, like this example:
Currently:
The text was updated successfully, but these errors were encountered: