Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Views: Bulk edit is hard to see as an option after selecting items #59043

Closed
annezazu opened this issue Feb 14, 2024 · 7 comments
Closed
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

After selecting a few items, the bulk edit button, while it shifts to the items you select, it's very hard to see:

Screenshot 2024-02-14 at 3 41 36 PM

I'm not sure if we should make it change to a primary button but it seems hard to discover currently. I could see folks selecting items then not knowing what to do next @WordPress/gutenberg-design

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Feb 14, 2024
@annezazu annezazu changed the title Data Views: Bulk edit is hard to see as an option after selecting options Data Views: Bulk edit is hard to see as an option after selecting items Feb 15, 2024
@t-hamano
Copy link
Contributor

At least, how about always making the label "Bulk actions" whether or not the item is selected, like in the classic editor?

Data Views:

image

Classic Editor:

image

Or we may want to move the button position itself. Since Bulk Edit is an action performed on checked items, I feel it is better to place it as close to the checkbox as possible.

image

@jameskoster
Copy link
Contributor

I feel it is better to place it as close to the checkbox as possible

I agree with the sentiment, but I don't like how the filters + bulk actions blend together. There's an argument to place search + filters closer in the DOM too. The composition is a bit tricky because the filter row can grow to be quite large so it needs a dedicated row.

For this issue specifically, the intention was always to try a 'floating bulk actions toolbar' (#55098), additional to the a11y-friendly menu that we have currently. This larger UI (which would ideally appear with some animation like a Snackbar to draw attention) should hopefully make the bulk actions more obvious. What do y'all think?

@t-hamano
Copy link
Contributor

The composition is a bit tricky because the filter row can grow to be quite large so it needs a dedicated row.

I certainly think so. Depending on other languages, the filter row will be longer.

The translation is not yet complete, but below is a screenshot comparing the length of the filter row in English and Japanese:

filter-row

For this issue specifically, the intention was always to try a 'floating bulk actions toolbar' (#55098), additional to the a11y-friendly menu that we have currently. This larger UI (which would ideally appear with some animation like a Snackbar to draw attention) should hopefully make the bulk actions more obvious. What do y'all think?

I think this is a great idea! I also learned that an implementation is already being explored in #56476.

@jameskoster
Copy link
Contributor

I also learned that an implementation is already being explored in #56476.

I think that PR also included the first attempt at general bulk action implementation. I wonder if it could be re-purposed to concentrate on the floating toolbar @jorgefilipecosta ?

@jorgefilipecosta
Copy link
Member

Hi @jameskoster, are there still plans to explore a floating toolbar?

@jameskoster
Copy link
Contributor

@jorgefilipecosta yes please 🙏 I think that's a good avenue to explore for this issue. Ideally the action bar would appear with some subtle animation to draw attention. We had this mockup before which can hopefully prove a good starting point:

Actions bar

@annezazu
Copy link
Contributor Author

annezazu commented Jun 5, 2024

Closing this out as #59714 landed!

@annezazu annezazu closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants